Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exec: fix tracking of matchBinary children #3186

Merged
merged 1 commit into from
Dec 10, 2024
Merged

exec: fix tracking of matchBinary children #3186

merged 1 commit into from
Dec 10, 2024

Conversation

kkourt
Copy link
Contributor

@kkourt kkourt commented Dec 5, 2024

No description provided.

@kkourt kkourt added kind/bug Something isn't working needs-backport/1.2 This PR needs backporting to 1.2 labels Dec 5, 2024
@kkourt kkourt marked this pull request as ready for review December 5, 2024 13:29
@kkourt kkourt requested a review from a team as a code owner December 5, 2024 13:29
@kkourt kkourt requested a review from tixxdz December 5, 2024 13:29
@kkourt kkourt added the release-note/bug This PR fixes an issue in a previous release of Tetragon. label Dec 5, 2024
@kkourt
exec: fix tracking of matchBinary children
41c7a74 
If we executed a binary that directly executed in another binary, the
->mb_bitset field was zeroed out and the information was lost, which
meant that the matching would not work as expected.

Fix this by i) not zeroing out the ->mb_bitset field and, also,
or it with the parent.

Add a test.

Fixes: e73718c ("exec: track matchbinary children")

Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
@kkourt kkourt force-pushed the pr/kkourt/matchibnaries-fix branch from 42837d5 to 41c7a74 Compare December 9, 2024 07:26
@kkourt kkourt requested a review from olsajiri December 9, 2024 07:27
@kkourt kkourt merged commit a1205b0 into main Dec 10, 2024
42 of 43 checks passed
@kkourt kkourt deleted the pr/kkourt/matchibnaries-fix branch December 10, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tixxdz tixxdz tixxdz approved these changes

@olsajiri olsajiri olsajiri approved these changes

Assignees
No one assigned
Labels
kind/bug Something isn't working needs-backport/1.2 This PR needs backporting to 1.2 release-note/bug This PR fixes an issue in a previous release of Tetragon.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kkourt @tixxdz @olsajiri