Skip to content

buf fixes #3417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kkourt merged 3 commits into from
Feb 18, 2025
Merged

buf fixes #3417

kkourt merged 3 commits into from
Feb 18, 2025

Conversation

@kkourt
Copy link
Contributor

@kkourt kkourt commented Feb 18, 2025 •
edited
Loading

See commits.

@kkourt kkourt changed the title Pr/kkourt/buf fixes buf fixes Feb 18, 2025
@kkourt kkourt added the release-note/misc This PR makes changes that have no direct user impact. label Feb 18, 2025
@kkourt kkourt force-pushed the pr/kkourt/buf-fixes branch from fb58dd5 to 4f7a53d Compare February 18, 2025 14:16
@kkourt kkourt marked this pull request as ready for review February 18, 2025 14:17
@kkourt kkourt requested a review from a team as a code owner February 18, 2025 14:17
@kkourt kkourt requested a review from kevsecurity February 18, 2025 14:17
will-isovalent
will-isovalent approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@will-isovalent will-isovalent left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll follow up with an upstream cilium-builder fix to bundle buf.build/grpc/go:v1.5.1 into the builder image. Actually the above is already done. I updated the first commit to use the local builder instead.

kkourt and others added 3 commits February 18, 2025 09:31
@kkourt @will-isovalent
api: configure buf to generate grpc code
0846117 
Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
Signed-off-by: William Findlay <will@isovalent.com>
@kkourt @will-isovalent
autochore: make protogen
b63b250 
Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
@will-isovalent
ci/generated_files: fix remote ref in buf checks
838db4e 
We had an issue where buf checks were not working in the push context of GitHub Actions
because `github.base_ref` is only defined in the PR context. Fix this by using
`github.ref` when `github.base_ref` is unavailable.

Signed-off-by: William Findlay <william.findlay@isovalent.com>
@kkourt kkourt merged commit 0e56d5d into main Feb 18, 2025
44 checks passed
@kkourt kkourt deleted the pr/kkourt/buf-fixes branch February 18, 2025 15:41
@BrewTestBot BrewTestBot mentioned this pull request Mar 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevsecurity kevsecurity kevsecurity approved these changes

@will-isovalent will-isovalent will-isovalent approved these changes

Assignees

No one assigned

Labels

release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kkourt @kevsecurity @will-isovalent