Skip to content

Conversation

@olsajiri
Copy link
Contributor

@olsajiri olsajiri commented Mar 7, 2025

strip kernels package so it's usable from other places and we don't need to have multiple functions returning kernel version

olsajiri added 3 commits March 7, 2025 14:41
Let's make config package global and move stuff in it in following
changes.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Moving GenericKprobeObjs to config package, because it makes
sense and we get one more bpf package dependency out of
kernels package.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Moving Enable* functions to config package, because it makes
sense and we get bpf package dependency out of kernels package.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
@olsajiri olsajiri added the release-note/minor This PR introduces a minor user-visible change label Mar 7, 2025
olsajiri added 2 commits March 7, 2025 15:17
Adding go:build !windows to kernels.go and removing the
_linux suffix, so it's usable for darwin.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Now that we trimmed kernels package, we can call
kernels.GetKernelVersion observerFindBTF.

Signed-off-by: Tristan d'Audibert <tristan.daudibert@orange.com>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
@olsajiri olsajiri force-pushed the pr/olsajiri/fixes branch from 56bb479 to 53b626d Compare March 7, 2025 15:18
@olsajiri olsajiri marked this pull request as ready for review March 7, 2025 16:08
@olsajiri olsajiri requested a review from a team as a code owner March 7, 2025 16:08
@olsajiri olsajiri requested a review from kkourt March 7, 2025 16:08
Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kkourt kkourt merged commit 931f409 into main Mar 10, 2025
43 checks passed
@kkourt kkourt deleted the pr/olsajiri/fixes branch March 10, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/minor This PR introduces a minor user-visible change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants