fix interval leak, updata metadata

cinatic · Apr 15, 2022 · eaf5f04 · eaf5f04
1 parent 0273227
commit eaf5f04
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 13 deletions.
diff --git a/kubectl@infinicode.de/components/k8sNavigationBar/k8sNavigationBar.js b/kubectl@infinicode.de/components/k8sNavigationBar/k8sNavigationBar.js
@@ -37,14 +37,14 @@ var K8sNavigationBar = GObject.registerClass({
       x_expand: true
     })
 
+    this.connect('destroy', this._onDestroy.bind(this))
+
     this._settingsChangedId = Settings.connect('changed', (value, key) => {
       if (SETTING_KEYS_TO_REFRESH.includes(key)) {
         this._sync()
       }
     })
 
-    this.connect('destroy', this._onDestroy.bind(this))
-
     this._sync()
   }
 
@@ -129,5 +129,8 @@ var K8sNavigationBar = GObject.registerClass({
   }
 
   _onDestroy () {
+    if (this._settingsChangedId) {
+      this._settingsChangedId = Settings.disconnect(this._settingsChangedId)
+    }
   }
 })
diff --git a/kubectl@infinicode.de/components/screens/defaultOverviewScreen/defaultOverviewScreen.js b/kubectl@infinicode.de/components/screens/defaultOverviewScreen/defaultOverviewScreen.js
@@ -159,7 +159,7 @@ var DefaultOverviewScreen = GObject.registerClass({
     }
 
     if (this._settingsChangedId) {
-      Settings.disconnect(this._settingsChangedId)
+      this._settingsChangedId = Settings.disconnect(this._settingsChangedId)
     }
   }
 })
diff --git a/kubectl@infinicode.de/metadata.json b/kubectl@infinicode.de/metadata.json
@@ -8,9 +8,11 @@
     "3.34",
     "3.36",
     "3.38",
-    "40"
+    "40",
+    "41",
+    "42"
   ],
   "url": "https://github.com/cinatic/kubectl-extension",
   "uuid": "kubectl@infinicode.de",
-  "version": 4
+  "version": 5
 }
diff --git a/kubectl@infinicode.de/po/de.po b/kubectl@infinicode.de/po/de.po
@@ -8,7 +8,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: \n"
 "Report-Msgid-Bugs-To: fh@infinicode.de\n"
-"POT-Creation-Date: 2021-04-17 22:08+0200\n"
+"POT-Creation-Date: 2022-03-04 14:13+0100\n"
 "PO-Revision-Date: 2020-11-30 14:42+0100\n"
 "Last-Translator: fh@infinicode.de\n"
 "Language-Team: German\n"
@@ -19,7 +19,7 @@ msgstr ""
 "Plural-Forms: nplurals=2; plural=(n != 1);\n"
 "X-Generator: Poedit 2.4.1\n"
 
-#: kubectl@infinicode.de/extension.js:55
+#: kubectl@infinicode.de/extension.js:56
 msgid "Kubectl"
 msgstr ""
 

diff --git a/kubectl@infinicode.de/po/kubectl@infinicode.de.pot b/kubectl@infinicode.de/po/kubectl@infinicode.de.pot
@@ -8,7 +8,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: gnome-shell-extension-kubectl\n"
 "Report-Msgid-Bugs-To: fh@infinicode.de\n"
-"POT-Creation-Date: 2021-04-17 22:08+0200\n"
+"POT-Creation-Date: 2022-04-15 11:22+0200\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <LL@li.org>\n"
@@ -17,7 +17,7 @@ msgstr ""
 "Content-Type: text/plain; charset=CHARSET\n"
 "Content-Transfer-Encoding: 8bit\n"
 
-#: kubectl@infinicode.de/extension.js:55
+#: kubectl@infinicode.de/extension.js:56
 msgid "Kubectl"
 msgstr ""
 

diff --git a/kubectl@infinicode.de/po/nl.po b/kubectl@infinicode.de/po/nl.po
@@ -7,18 +7,18 @@ msgid ""
 msgstr ""
 "Project-Id-Version: gnome-shell-extension-kubectl\n"
 "Report-Msgid-Bugs-To: fh@infinicode.de\n"
-"POT-Creation-Date: 2021-04-17 22:08+0200\n"
+"POT-Creation-Date: 2022-04-15 11:22+0200\n"
 "PO-Revision-Date: 2021-07-16 14:19+0200\n"
+"Last-Translator: Heimen Stoffels <vistausss@fastmail.com>\n"
 "Language-Team: \n"
+"Language: nl\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"
 "X-Generator: Poedit 3.0\n"
-"Last-Translator: Heimen Stoffels <vistausss@fastmail.com>\n"
 "Plural-Forms: nplurals=2; plural=(n != 1);\n"
-"Language: nl\n"
 
-#: kubectl@infinicode.de/extension.js:55
+#: kubectl@infinicode.de/extension.js:56
 msgid "Kubectl"
 msgstr "Kubectl"