Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Update travis CI to use only supported ubuntu images #2199

Merged
merged 3 commits into from
Sep 22, 2020

Conversation

MikeGitb
Copy link
Contributor

@MikeGitb MikeGitb commented Sep 3, 2020

The oldest ubuntu distro, compiler and c++ standard and cmake version supported by cinder have changed quite a bit.
Also travis itself has changed the environments it provides and what options are available.
This PR cleans up the travis-ci file and tests cinder only with the default g++ and clang++ compiler on ubuntu bionic and focal respectively.

The main goal here is to make the ci-results usable again for development. Extending the test matrix to more compilers and more standard settings is left for a future PR.

@MikeGitb MikeGitb mentioned this pull request Sep 3, 2020
26 tasks
@MikeGitb
Copy link
Contributor Author

MikeGitb commented Sep 3, 2020

TODO: also fix OSX runs

@MikeGitb MikeGitb force-pushed the pr/fix/update_distro_on_travis branch 4 times, most recently from 977bdb2 to 8071fb7 Compare September 3, 2020 12:34
@MikeGitb MikeGitb force-pushed the pr/fix/update_distro_on_travis branch from 8071fb7 to 2a3172d Compare September 3, 2020 12:40
@MikeGitb
Copy link
Contributor Author

MikeGitb commented Sep 3, 2020

Note: This PR also deactivates two test on macos with older xcode versions, as the cmake version there is 3.9. As I don't have a mac, I don't know what the fastest way to install a newer cmake version would be. Using brew upgrade cmake seems possible, but that leeds to excessive build times as it first also installs several dependencies.

@andrewfb andrewfb merged commit b389149 into cinder:master Sep 22, 2020
@andrewfb
Copy link
Collaborator

Thanks for this update

@MikeGitb MikeGitb deleted the pr/fix/update_distro_on_travis branch September 22, 2020 06:40
@alias-r-cummins
Copy link

I'd be happy to set up a Bitrise CI integration, they've offered us a free plan:

https://blog.bitrise.io/free-developer-plan-features-for-open-source-projects-on-bitrise

@alias-r-cummins
Copy link

The reason for insisting on CMake 3.10.2 is that it's what is bundled with Android Studio, so it's available on Mac, PC and Linux.

@MikeGitb
Copy link
Contributor Author

MikeGitb commented Dec 3, 2020

it's what is bundled with Android Studio, so it's available on Mac, PC and Linux.

Only when android studio is installed. People like me don't write Software for Android ;). Well, I'm using latest cmake anyway but I've no Idea what the typical MacOS dev environment looks like.

@alias-r-cummins
Copy link

Right. But the object of this exercise is to make it as easy as possible for people who do.

Ideally, and Android developer wants to install Android Studio and nothing else, and be able to build Cinder from source, and deploy it to the Play Store. This is a normal use case.

@alias-r-cummins
Copy link

Anyway. You don't need a mac or an android device, because bitrise now runs a CI pipeline which checks everything.

https://app.bitrise.io/build/88e8d685acd39547#?tab=log

With regard to toolchains - I don't know a single Android developer who doesn't use Android studio. It's theoretically possible with a lot of expensive and time consuming custom scripting, but this is best avoided if at all possible. We want Cinder for Android to work as easily as possible, out of the box.

@alias-r-cummins
Copy link

@MikeGitb Just out of interest, do you mainly write for Windows & Linux? I'm keen to cover those bases too.

@MikeGitb
Copy link
Contributor Author

MikeGitb commented Dec 3, 2020

I think we should move this discussion back to #2208 (wrote a comment there) I only linked this PR, because the question of how to install recent versions of cmake on mac came up when I created this PR too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants