Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dev branch docker images to registry #1790

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

Curious-r
Copy link

Description

This PR will provide images with "dev" tag in dockerhub and ghcr. After this change, the "latest" tag in registry will point to the newest release, and "dev" tag will point to the image with the last commit in dev branch. #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

github-actions bot commented Jun 30, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Curious-r
Copy link
Author

PTAL @kfiven

@Curious-r
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

ajbura added a commit to cinnyapp/cla that referenced this pull request Jun 30, 2024
Comment on lines +3 to +6
on:
push:
branches:
- dev
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for working on this. Can we please not run this on every commit as this would be very resource intensive. I think once a week or something similar would be best for this action.

Copy link
Author

@Curious-r Curious-r Jul 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply. I have make an update, add a job to ensure that the interval between image publishes is greater than a week.
And there is a question: is DOCKER_PASSWORD a Docker Hub token? Although it doesn't matter even if it's ineffective, I'm just using it to avoid the rate limit of API requests.
Thanks!

Copy link
Collaborator

@kfiven kfiven Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, no worries! Can we setup it like a separate action and do the schedule part as explained in Action docs as it seems much easier.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'docker/metadata-action' and 'docker/build-push-action' use git ref of the event that triggers the workflow to automate a lot of things, changing to schedule, we need to configure it in a more complex way.
Or we can just delete -H "Authorization: Bearer ${{ secrets.DOCKER_PASSWORD }}" in curl command, our use case doesn't cause rate limiting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants