-
-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dev branch docker images to registry #1790
base: dev
Are you sure you want to change the base?
Conversation
All contributors have signed the CLA ✍️ ✅ |
PTAL @kfiven |
I have read the CLA Document and I hereby sign the CLA |
on: | ||
push: | ||
branches: | ||
- dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for working on this. Can we please not run this on every commit as this would be very resource intensive. I think once a week or something similar would be best for this action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late reply. I have make an update, add a job to ensure that the interval between image publishes is greater than a week.
And there is a question: is DOCKER_PASSWORD
a Docker Hub token? Although it doesn't matter even if it's ineffective, I'm just using it to avoid the rate limit of API requests.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, no worries! Can we setup it like a separate action and do the schedule part as explained in Action docs as it seems much easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'docker/metadata-action' and 'docker/build-push-action' use git ref of the event that triggers the workflow to automate a lot of things, changing to schedule, we need to configure it in a more complex way.
Or we can just delete -H "Authorization: Bearer ${{ secrets.DOCKER_PASSWORD }}"
in curl command, our use case doesn't cause rate limiting.
Description
This PR will provide images with "dev" tag in dockerhub and ghcr. After this change, the "latest" tag in registry will point to the newest release, and "dev" tag will point to the image with the last commit in dev branch. #
Type of change
Checklist: