Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate EQL uninstall #36

Merged
merged 5 commits into from
Oct 24, 2024
Merged

Generate EQL uninstall #36

merged 5 commits into from
Oct 24, 2024

Conversation

tobyhede
Copy link
Contributor

@tobyhede tobyhede commented Oct 23, 2024

Build now generates:

  • cipherstash-encrypt-uninstall.sql
  • cipherstash-encrypt.sql

At no extra charge:

  • add release files to gitignore
  • makes sure every entity has a drop
  • various small tweaks

Copy link
Contributor

@auxesis auxesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question I have about the release/*.sql files:

Should we be committing those artifacts to the repo?

The general practice is to not, but we seem to be doing so.

Normally a git repo should contain all the bits required to build artifacts, but the build system is responsible for storing and serving those artifacts.

@fimac
Copy link
Contributor

fimac commented Oct 23, 2024

One question I have about the release/*.sql files:

Should we be committing those artifacts to the repo?

The general practice is to not, but we seem to be doing so.

Normally a git repo should contain all the bits required to build artifacts, but the build system is responsible for storing and serving those artifacts.

I think it would be good to have it there, so we can point the orm examples to that file instead of copying it over into each example.

@fimac
Copy link
Contributor

fimac commented Oct 23, 2024

@auxesis
Copy link
Contributor

auxesis commented Oct 23, 2024

I think it would be good to have it there, so we can point the orm examples to that file instead of copying it over into each example.

That's a fair point, it is convenient to be able to reference it inside the repo.

That said, there is a quick URL to access the latest EQL release from GitHub:

curl -sLo cipherstash-eql.sql https://github.com/cipherstash/encrypt-query-language/releases/latest/download/cipherstash-eql.sql

@calvinbrewer calvinbrewer merged commit 90dd73b into main Oct 24, 2024
1 check passed
@calvinbrewer calvinbrewer deleted the uninstall branch October 24, 2024 15:57
@calvinbrewer calvinbrewer restored the uninstall branch October 24, 2024 18:51
auxesis added a commit that referenced this pull request Oct 25, 2024
To match release process and changes in #30, #35, #36, #38.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants