-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate EQL uninstall #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question I have about the release/*.sql
files:
Should we be committing those artifacts to the repo?
The general practice is to not, but we seem to be doing so.
Normally a git repo should contain all the bits required to build artifacts, but the build system is responsible for storing and serving those artifacts.
I think it would be good to have it there, so we can point the orm examples to that file instead of copying it over into each example. |
@tobyhede it would be good to include the uninstall.sql for ore types as well. https://github.com/cipherstash/encrypt-query-language/blob/main/sql/database-extensions/postgresql/uninstall.sql |
That's a fair point, it is convenient to be able to reference it inside the repo. That said, there is a quick URL to access the latest EQL release from GitHub:
|
Build now generates:
At no extra charge:
gitignore
drop