Use same drop setup on install and uninstall #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobyhede
commented
Feb 20, 2025
| @@ -184,8 +184,8 @@ DROP OPERATOR IF EXISTS = (ore_64_8_index_v1, ore_64_8_index_v1); | |||
|
|
|||
| CREATE OPERATOR = ( | |||
| PROCEDURE="ore_64_8_v1_eq", | |||
| LEFTARG=ore_64_8_v1, | |||
| RIGHTARG=ore_64_8_v1, | |||
| LEFTARG=ore_64_8_index_v1, | |||
There was a problem hiding this comment.
The drop failure was hiding that the type name had changed
auxesis
approved these changes
Feb 21, 2025
CDThomas
added a commit
that referenced
this pull request
Feb 25, 2025
This change reverts this repo back to 01dcc24. The changes reverted include commits from: - #86 - #87 We mostly want to revert the changes in #86 (since they aren't working as intended with Proxy), but #87 is also included since it's more recent (and also includes some ORE-related changes that would be tedious to untangle). Since there aren't many changes after #86, the most pragmatic option is to revert to the last known-good state and redo the install/uninstall changes by hand on top of that. Commands used to revert: ``` git reset --hard 01dcc24 git reset --soft ed460fc ``` This change doesn't use `git revert` because there were > 20 commits to revert and merge commits also don't play well with `git revert`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate a single sql file containing all of the drops and use this for both install and uninstall.