Parse ORE indexes as JSON arrays of hex-encoded strings #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates `cs_ore_64_8_v1` to parse ORE indexes (the `'o'` field) as JSON arrays of hex-encoded strings (instead of casting from the Postgres text format). The corresponding change for encoding ORE indexes as JSON arrays of hex-encoded stings has already been merged in Proxy. This is similar to some of the changes in #86, but we're parsing into the composite types for ORE indexes instead of into a plain `bytea[]`. Parsing into the composite type allows for ordering with an operator class on the output from `cs_ore_64_8_v1`.
CDThomas
force-pushed
the
feat/parse-ore-as-json-array
branch
from
bb15856 to
e3e291e
Compare
tobyhede
approved these changes
Feb 25, 2025
| DECLARE | ||
| terms_arr ore_64_8_v1_term[]; | ||
| BEGIN | ||
| IF jsonb_typeof(val) = 'null' THEN |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates
cs_ore_64_8_v1to parse ORE indexes (the'o'field) as JSON arrays of hex-encoded strings (instead of casting from the Postgres text format).The corresponding change for encoding ORE indexes as JSON arrays of hex-encoded strings has already been merged in Proxy.
This is similar to some of the changes in #86, but we're parsing into the composite types for ORE indexes instead of into a plain
bytea[]. Parsing into the composite type allows for ordering with an operator class on the output fromcs_ore_64_8_v1.