-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mask for entangling gates #32
Conversation
Codecov Report
@@ Coverage Diff @@
## main #32 +/- ##
==========================================
+ Coverage 75.13% 78.60% +3.46%
==========================================
Files 15 15
Lines 1122 1173 +51
Branches 108 117 +9
==========================================
+ Hits 843 922 +79
+ Misses 275 246 -29
- Partials 4 5 +1
Continue to review full report at Codecov.
|
ce6ede1
to
26f84e0
Compare
@maxfischer2781, when reviewing, please have a specific look on how the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only sprinkled is not None
s on the cases that were relying on implicit falseyness. That's somewhat faster and should be more robust if you ever refactor.
Do you think you can hit the continue
s with unittests? I can't really comment on whether they work as expected.
Co-authored-by: Max Fischer <maxfischer2781@gmail.com>
Sorry, I missed your previous comment. TBH I'm not totally sure how exactly this change works, so it's hard for me to say how it might affect other things. Perhaps we should discuss at a literal drawing board. :P |
I added another unit test that should exactly test for that :) Now you will have to review again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sneaky just raising the coverage while I was looking... 😜
This PR adds functionality to support removal of entangling gates from a given circuit via
Mask
s. Idea to support this feature is to explicitly support lowering the expressivity of a quantum circuit and therefore maybe raising the trainability.Closes #31.