Documentation, test and normalization for cross entropy calculation #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ce_fix #45 +/- ##
==========================================
- Coverage 76.43% 75.58% -0.85%
==========================================
Files 15 16 +1
Lines 1379 1110 -269
Branches 147 107 -40
==========================================
- Hits 1054 839 -215
+ Misses 321 267 -54
Partials 4 4
Continue to review full report at Codecov.
|
|
@cDenius, you can happily ignore that one failing test regarding project coverage :) |
cDenius
requested changes
Sep 9, 2021
eileen-kuehn
changed the title
maxfischer2781
approved these changes
Sep 9, 2021
eileen-kuehn
added a commit
that referenced
this pull request
Sep 9, 2021
* Divide by sample size * Document, test and normalize cross entropy calculation (#45) Co-authored-by: Christof Wendenius <christof.wendenius@kit.edu> Co-authored-by: Eileen Kuehn <eileen.kuehn@kit.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends documentation for the cross entropy calculation and adds normalisation as well as a simple unit test based on the discussion in Stackoverflow.
Closes #47.