This repository has been archived by the owner on Jan 28, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
R1CS output flatbuffer #14
Open
elefthei
wants to merge
1
commit into
master
Choose a base branch
from
flatbuffer-serialize
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -83,6 +83,7 @@ import System.IO ( hPutStr | |
, IOMode(WriteMode) | ||
, hClose | ||
) | ||
import Util.Cfg ( R1CSOutput(..) ) | ||
-- Faster IO? | ||
-- import qualified Data.Text.IO as TextIO | ||
-- import System.IO ( openFile | ||
|
@@ -362,10 +363,12 @@ r1csAsLines r1cs = | |
in [nPubIns, nWit, nConstraints] : constraintLines | ||
|
||
-- Todo: implement this using a better IO system. | ||
writeToR1csFile :: (Show s, KnownNat n) => Bool -> R1CS s n -> FilePath -> IO () | ||
writeToR1csFile asJson r1cs path = if asJson | ||
then ByteString.writeFile path $ encode r1cs | ||
else writeFile path $ unlines $ map (unwords . map show) $ r1csAsLines r1cs | ||
writeToR1csFile | ||
:: (Show s, KnownNat n) => R1CSOutput -> R1CS s n -> FilePath -> IO () | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would lift this to the |
||
writeToR1csFile Json r1cs path = ByteString.writeFile path $ encode r1cs | ||
writeToR1csFile FlatBuffer r1cs path = undefined -- TODO when we get the schema from SGA | ||
writeToR1csFile Legacy r1cs path = | ||
writeFile path $ unlines $ map (unwords . map show) $ r1csAsLines r1cs | ||
-- else do | ||
-- h <- openFile path WriteMode | ||
-- forM_ (r1csAsLines r1cs) $ \line -> do | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,6 +16,7 @@ module Util.Cfg | |
, defaultCfgState | ||
, evalCfg | ||
, evalCfgDefault | ||
, R1CSOutput(..) | ||
) | ||
where | ||
|
||
|
@@ -42,6 +43,8 @@ data SmtOptCfg = SmtOptCfg { _allowSubBlowup :: Bool | |
, _benesThresh :: Int | ||
} deriving (Show) | ||
|
||
data R1CSOutput = Json | Legacy | FlatBuffer deriving (Show, Eq) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would add this to the configuration system |
||
|
||
defaultSmtOptCfg :: SmtOptCfg | ||
defaultSmtOptCfg = SmtOptCfg | ||
{ _allowSubBlowup = False | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would drop this (and other
asJson
handling), in favor of aCfg
-based approach.