Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONPREM-1836] Document other agents requiring hosting in air-gap #9181

Merged
merged 8 commits into from
Jan 24, 2025

Conversation

christian-stephen
Copy link
Member

Description

A brief description of the changes.

The existing docs missed a couple agents that also require re-hosting.

Reasons

A link to a GitHub and/or JIRA issue (if applicable).
Otherwise, a brief sentence about why you made these changes.

https://circleci.atlassian.net/browse/ONPREM-1836

Content Checklist

Please follow our style when contributing to CircleCI docs. Our style guide is here: https://circleci.com/docs/style/style-guide-overview.

Please take a moment to check through the following items when submitting your PR (this is just a guide so will not be relevant for all PRs) 😸:

  • Break up walls of text by adding paragraph breaks.
  • Consider if the content could benefit from more structure, such as lists or tables, to make it easier to consume.
  • Keep the title between 20 and 70 characters.
  • Consider whether the content would benefit from more subsections (h2-h6 headings) to make it easier to consume.
  • Check all headings h1-h6 are in sentence case (only first letter is capitalized).
  • Is there a "Next steps" section at the end of the page giving the reader a clear path to what to read next?
  • Include relevant backlinks to other CircleCI docs/pages.

@christian-stephen christian-stephen requested a review from a team January 16, 2025 16:25
@christian-stephen christian-stephen requested review from a team as code owners January 16, 2025 16:25
Copy link
Contributor

@marcospereira-circleci marcospereira-circleci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestions.

@christian-stephen christian-stephen force-pushed the ONPREM-1836/rehost-other-agents-in-air-gap branch from 5654dc7 to adf49fb Compare January 22, 2025 19:03
@christian-stephen christian-stephen force-pushed the ONPREM-1836/rehost-other-agents-in-air-gap branch from adf49fb to 84e55de Compare January 22, 2025 19:03
Copy link
Contributor

@rosieyohannan rosieyohannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny change really!

Co-authored-by: Rosie Yohannan <rosie@circleci.com>
@christian-stephen
Copy link
Member Author

@rosieyohannan, thanks! Applied your suggestion

Copy link
Contributor

@rosieyohannan rosieyohannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@christian-stephen christian-stephen merged commit 18fd624 into master Jan 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants