Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rails 7 support #1

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Add Rails 7 support #1

merged 2 commits into from
Jun 5, 2024

Conversation

diazweb
Copy link
Contributor

@diazweb diazweb commented Jun 5, 2024

Error message using Rails 7:

And because rails >= 7.1.3.4, < 7.2.0.beta1 depends on activejob = 7.1.3.4
  and every version of sidekiq_job_controller depends on activejob ~> 6.0,
  every version of sidekiq_job_controller is incompatible with rails >= 7.1.0.

This change allows up to Rails 7.1

Error message using Rails 7:

```
And because rails >= 7.1.3.4, < 7.2.0.beta1 depends on activejob = 7.1.3.4
  and every version of sidekiq_job_controller depends on activejob ~> 6.0,
  every version of sidekiq_job_controller is incompatible with rails >= 7.1.0.
``` 

This change allows up to Rails 7.1
@diazweb diazweb requested a review from silva96 June 5, 2024 15:02
@silva96
Copy link
Member

silva96 commented Jun 5, 2024

Build is failing, i suspect we need to run do this:

Run bundle install elsewhere and add the updated Gemfile.lock to version

@silva96 silva96 merged commit a856a7f into main Jun 5, 2024
1 check passed
@silva96 silva96 deleted the add-rails-7-support branch June 5, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants