Correct arguments in Tornado get_arguments() usage #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method returns an empty list by default, and the second parameter, 'strip,' is a flag to enable stripping of the result strings. In recent versions of Tornado (4.2.1 here) the 'strip' parameter is checked with an assert to ensure that its type is Bool, and this Raises in circus-web. Previously, the empty list [] would have evaluated Falsey, so removing the second parameter keeps the same behavior, while fixing the call in newer versions of Tornado. Also see #59
|
Hello, what is the status with this FIX, and any reason this hasn't been merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method returns an empty list by default, and the second parameter,
'strip,' is a flag to enable stripping of the result strings. In recent
versions of Tornado (4.2.1 here) the 'strip' parameter is checked with
an assert to ensure that its type is Bool, and this Raises in
circus-web.
Previously, the empty list [] would have evaluated Falsey, so removing
the second parameter keeps the same behavior, while fixing the call in
newer versions of Tornado.
Also see
#59