Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Kindle Comic Converter has the version number 0.0.0 #632

Open
core-code opened this issue Nov 29, 2023 · 7 comments
Open

[macOS] Kindle Comic Converter has the version number 0.0.0 #632

core-code opened this issue Nov 29, 2023 · 7 comments
Assignees
Labels
Bug Something isn't working macOS

Comments

@core-code
Copy link

starting with version 5.6.3 and including version 5.6.4 the Kindle Comic Converter claims to have version "0.0.0"

previous versions up to 5.6.2 did not have this problem, so this is a regression. starting with 5.6.3, the in your Info.plist file the CFBundleVersion was removed (which is a clear bug and should never happen) and the CFBundleShortVersionString was set to "0.0.0" (which is just nonsense)

screenshots from the Finder's GetInfo, ColumnView and QuickLook:
Screenshot 2023-11-29 at 19 13 54
Screenshot 2023-11-29 at 19 14 09
Screenshot 2023-11-29 at 19 13 37

@core-code
Copy link
Author

Screenshot 2023-11-29 at 19 13 30

@darodi
Copy link
Collaborator

darodi commented Nov 29, 2023

@axu2

might be related to
1318b9c

Info.plist was removed and version change from setup.py

@darodi darodi added this to the 5.6.5 milestone Nov 29, 2023
@darodi darodi added the Bug Something isn't working label Nov 29, 2023
@axu2
Copy link
Collaborator

axu2 commented Nov 29, 2023

Yes, I removed our info.plist since it caused tons of issues. pyinstaller provided defaults values like 0.0.0. Copying files after the fact manually into a .app causes tons of issues.

@core-code
Copy link
Author

The proper fix will probably involve modifying the pyinstaller command.

since the app is unsigned you could also process the Info.plist after the build step e.g. using /usr/libexec/PlistBuddy

@axu2 axu2 added the macOS label Nov 29, 2023
@axu2
Copy link
Collaborator

axu2 commented Nov 30, 2023

since the app is unsigned you could also process the Info.plist after the build step e.g. using /usr/libexec/PlistBuddy

Changing the version number after building results in the original damaged error.

image

The proper way to do this is to switch from building directly from the .py to adding the intermediate .spec step.

@darodi

This comment has been minimized.

@axu2 axu2 modified the milestones: 5.6.5, 6.0 Mar 22, 2024
@axu2 axu2 removed this from the 7.0 milestone Jul 1, 2024
@core-code
Copy link
Author

still not fixed in 6.2.0, it still claims to be 0.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working macOS
Projects
None yet
Development

No branches or pull requests

3 participants