Fix Mac CBZ, CBR, cover upload, damaged #566
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Mac CBZ, CBR, damaged, cover upload, when frozen
Frozen is referring to a binary frozen by PyInstaller.
Copying files into the PyInstaller
.app
appears to cause a whole lot of issues. Don't see a reason to not use homebrew 7z and the PyInstaller default plist. Plus homebrew stuff like 7z/unar is in a different location on M1.Also removed the PATH words since that's not needed anymore.
Thank you to @maxthiel at #528 (comment) for testing
Thank you to @killam42 : #569 (comment) for testing
Beta Mac dmg for testing: https://github.com/axu2/kcc/actions/runs/5709825357Updated dmg: https://github.com/axu2/kcc/actions/runs/5746658564
Also will open errors in separate window, like if you didn't
brew install unar
. Using separate window since unpacking errors can be LONG:7z doesn't support rar on Mac.
unrar doesn't exist on Mac.
unar does.
Just brew install unar
In the meantime use a separate app like unarchiver to extract the files first before putting them into kcc. May be better option for linux and fedora.
@Evidlo @cookie99999 @AlicesReflexion @aliafshany @jthulhu @celogeek