-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Mac CBZ, CBR, cover upload, damaged #566
Conversation
@maxthiel @killam42 feel free to test the CBR build here and report if it works: https://github.com/axu2/kcc/actions/runs/5746658564 |
I'm not sure on why I was pinged, I am not a maintainer of this repo. |
Hi @axu2 , I'm getting this error with the build above: Which is promptly solved by a |
@axu2 ok, I appreciate the intention :) I didn't remember that issue, it was too much time ago. Btw, the issue was under Linux, if that can help. |
Looks like I've blurred to much! |
Thanks to @borako for testing. |
@darodi could we get a bugfix release out with this? Mac support requests are getting too frequent, since our currently provided dmg is pretty broken. Numerous Mac users have already tested this build. |
.decode("utf-8") edit kindlegen text adjust 7z text add unar delete spec remove 7z binaries change path priorities add 7z location for m1 delete plist fix mac cover upload
Fix Mac CBZ, CBR, damaged, cover upload, when frozen
Frozen is referring to a binary frozen by PyInstaller.
Copying files into the PyInstaller
.app
appears to cause a whole lot of issues. Don't see a reason to not use homebrew 7z and the PyInstaller default plist. Plus homebrew stuff like 7z/unar is in a different location on M1.Also removed the PATH words since that's not needed anymore.
Thank you to @maxthiel at #528 (comment) for testing
Thank you to @killam42 : #569 (comment) for testing
Beta Mac dmg for testing: https://github.com/axu2/kcc/actions/runs/5709825357Updated dmg: https://github.com/axu2/kcc/actions/runs/5746658564
Also will open errors in separate window, like if you didn't
brew install unar
. Using separate window since unpacking errors can be LONG:7z doesn't support rar on Mac.
unrar doesn't exist on Mac.
unar does.
Just brew install unar
In the meantime use a separate app like unarchiver to extract the files first before putting them into kcc. May be better option for linux and fedora.
@Evidlo @cookie99999 @AlicesReflexion @aliafshany @jthulhu @celogeek