-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix page order and bookmarks by renaming numerically #507
Conversation
Here's a file I used for testing has special characters, whitespace, japanese: Make sure generated file confirms to EPUB 3.3 https://github.com/w3c/epubcheck |
Main issue is with files with a |
My conclusion: slugify was needed to conform to EPUB standards. But will re-order files. Only solution is to completely re-name files like mangle. But realistically, no one cares what the filenames are after conversion. |
Decided to rename pages numerically 0000.jpg 0001.jpg etc. We actually already do this for KOBO. |
Can delete this:
since we aren't preserving original names at all anymore. We might have issues with files that look like 0000-kcc.jpg originally, but that's an expected error, if someone is re-processing KCC files somehow by mistake and the UI will warn issues might happen. Added KCC to start and end of file. |
@axu2 |
Oh that's right, we can remove the Kobo one too since they are doing the same thing now. |
Thank you to @vinhtq115 for extensive testing in #558 Looks like this now: |
Fix Page Order Issue:
Fix various bookmark issues due to kcc-b logic:
(I suspect larger files made by comicrack are more likely to have bookmarks that cause issues).
Don't rename files with slugify and fix the bookmark drift issue.
Hasn't caused any issues in the files I've tested however, with flat files and subdirectories.
@cyberbad @4AM-Campfire @VictorGamerLOL @Scotsguy @tao-cumplido @ahihh @noahastor @Jhoelious @crevopunch @augustebaum @origaniels
#46 seems related