Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cropping power sliders #793

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Fix cropping power sliders #793

merged 2 commits into from
Dec 31, 2024

Conversation

axu2
Copy link
Collaborator

@axu2 axu2 commented Dec 31, 2024

For some reason, Qt creator will delete several lines from the .ui file after

was commited. This messed up the cropping power sliders. So this is putting it back to how it was originally.

@neyney10 The only UI change should have been changing the UI slider maximum from 2 to 3, do you remember how those extra changes snuck in there? It was probably a Qt6 version mismatch though. I need to enforce the version.

I fixed this file with a git checkout c35dd137eaca8f3e006f02d52f2167c4b3375dd9 gui/KCC.ui

@axu2 axu2 changed the title Fix gui Fix cropping power sliders Dec 31, 2024
@axu2 axu2 merged commit 0a4ef31 into ciromattia:master Dec 31, 2024
@axu2 axu2 deleted the fix-gui branch December 31, 2024 03:15
@neyney10
Copy link
Contributor

For some reason, Qt creator will delete several lines from the .ui file after

* [A better page number-crop algorithm with NumPy. (Manga) #709](https://github.com/ciromattia/kcc/pull/709)

was commited. This messed up the cropping power sliders. So this is putting it back to how it was originally.

@neyney10 The only UI change should have been changing the UI slider maximum from 2 to 3, do you remember how those extra changes snuck in there? It was probably a Qt6 version mismatch though. I need to enforce the version.

I fixed this file with a git checkout c35dd137eaca8f3e006f02d52f2167c4b3375dd9 gui/KCC.ui

Yes I noticed them too. i didn't understand why the width changed while I didn't make any width changes and it doesn't seem to display them any differently on my end, so I figured its okay. i assume it is because I used a newer version of Qt or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants