This repository has been archived by the owner on May 7, 2024. It is now read-only.
Retry if the PR is unrebaseable #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkorotkov
reviewed
May 6, 2021
entrypoint.sh
Outdated
|
|
||
| if [[ "$REBASEABLE" != "true" || "$i" == "$MAX_RETRIES" ]] ; then | ||
| echo "GitHub doesn't think that the PR is rebaseable!" | ||
| echo "API response: $pr_resp" |
There was a problem hiding this comment.
Let's not print the response here. It was a CVE https://bugs.chromium.org/p/project-zero/issues/detail?id=2070
fkorotkov
reviewed
May 6, 2021
entrypoint.sh
Outdated
| fi | ||
| done | ||
|
|
||
| if [[ "$REBASEABLE" != "true" || "$i" == "$MAX_RETRIES" ]] ; then |
There was a problem hiding this comment.
Also no need to check for i value. Not even sure if it's still available here. 🤔
Suggested change
| if [[ "$REBASEABLE" != "true" || "$i" == "$MAX_RETRIES" ]] ; then | |
| if [[ "$REBASEABLE" != "true" ]] ; then |
There was a problem hiding this comment.
You're right, it no need to check for i.
fkorotkov
approved these changes
May 7, 2021
|
@ddzero2c thank you for the PR! |
xzile
pushed a commit
to Interfolio/rebase
that referenced
this pull request
Apr 19, 2022
* Retry if the PR is unrebaseable * Remove useless code (cherry picked from commit 1eb6e5e)
xzile
pushed a commit
to Interfolio/rebase
that referenced
this pull request
Apr 19, 2022
* Retry if the PR is unrebaseable * Remove useless code (cherry picked from commit 1eb6e5e)
xzile
pushed a commit
to Interfolio/rebase
that referenced
this pull request
Apr 19, 2022
* Retry if the PR is unrebaseable * Remove useless code (cherry picked from commit 1eb6e5e)
cjw6k
pushed a commit
to SonarSoftwareInc/rebase
that referenced
this pull request
Apr 26, 2022
* Retry if the PR is unrebaseable * Remove useless code
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix issue 72