Document danger of using COPY and ADD instructions #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RDIL
reviewed
Jan 7, 2021
| !!! warning "Danger of using `COPY` and `ADD` instructions" | ||
| Cirrus doesn't include files added or copied into a container image in the cache key. This means that for a public repository | ||
| a potential bad actor can create a PR with malicious scripts included into a container, wait for it to be cached and then | ||
| reset the PR so it looks harmful. |
There was a problem hiding this comment.
That doesn't sound quite right... you mean reset the PR so it doesn't look harmful?
There was a problem hiding this comment.
Reset PR branch. Like modify scripts that are added to not look harmful.
There was a problem hiding this comment.
I think @RDIL meant "s/harmful/not harmful/". Maybe it's good to add one or two sentences about the consequences, e.g., what a malicious script could do.
There was a problem hiding this comment.
Oh, yeah, some other folks noticed it and I fixed the harmfull thing in 51474e1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.