Persistent DHCP identifier fix #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkorotkov
approved these changes
Oct 8, 2024
This was referenced Jan 15, 2025
nirs
added a commit
to nirs/lima
that referenced
this pull request
Jan 18, 2025
On macOS the DHCP server use the DUID+IAID for both hw_address and
identifier, which makes it harder to discover the machine mac address by
looking up leases in /var/db/dhcpd_leases. It seems that this issue
started in macOS 15.
% cat /var/db/dhcpd_leases
{
name=lima-test
ip_address=192.168.105.4
hw_address=ff,5c:bb:eb:5e:0:2:0:0:ab:11:72:3e:92:23:14:1d:a7:ba
identifier=ff,5c:bb:eb:5e:0:2:0:0:ab:11:72:3e:92:23:14:1d:a7:ba
lease=0x678b8aee
}
With this change the record is created using the mac address:
% cat /var/db/dhcpd_leases
{
name=lima-test
ip_address=192.168.105.4
hw_address=1,52:55:55:ba:82:85
identifier=1,52:55:55:ba:82:85
lease=0x678b90c6
}
The fix is based on:
cirruslabs/linux-image-templates#39.
Minikube have the similar (networkd specific) fix:
kubernetes/minikube#3572
Signed-off-by: Nir Soffer <nirsof@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we disable all data sources above to speed-up the booting process, we need to somehow provide our DHCP identifier fix from "network-config".
Otherwise the fix will only be visible on the initial VM boot, which I was testing #38 on.