Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement paging for extracted files download dialog #361

Closed
mmguero opened this issue Nov 4, 2024 · 4 comments
Closed

implement paging for extracted files download dialog #361

mmguero opened this issue Nov 4, 2024 · 4 comments
Assignees
@mmguero @jjrush
Labels
carving Relating to carving (extraction) of files from traffic and the scanning of those files enhancement New feature or request UI Relating to general UI experience
Milestone
v24.11.0

Comments

@mmguero
Copy link
Collaborator

mmguero commented Nov 4, 2024

@mmguero cloned issue idaholab/Malcolm#595 on 2024-10-15:

We should implement paging in the extracted_files_http_server.py.

Pick something like a page size of 50 and have next/previous buttons at the bottom or top.
@mmguero mmguero added carving Relating to carving (extraction) of files from traffic and the scanning of those files enhancement New feature or request UI Relating to general UI experience labels Nov 4, 2024
@mmguero
Copy link
Collaborator Author

mmguero commented Nov 4, 2024

@jjrush commented on 2024-10-24:

I have this implemented and tested on a branch in my fork. Will work to get it added to a future release.

@mmguero
Copy link
Collaborator Author

mmguero commented Nov 4, 2024

@mmguero commented on 2024-10-24:

I have this implemented and tested on a branch in my fork. Will work to get it added to a future release.

Thanks, just submit a PR to this repo and I'll get it staged for v24.11.0.

@mmguero mmguero mentioned this issue Nov 4, 2024
Closed
@mmguero mmguero added this to Malcolm Nov 5, 2024
@mmguero mmguero moved this to Testing in Malcolm Nov 5, 2024
@mmguero mmguero moved this from Testing to Review in Malcolm Nov 5, 2024
@mmguero mmguero added this to the v24.11.0 milestone Nov 5, 2024
@mmguero mmguero moved this from Review to Testing in Malcolm Nov 12, 2024
@mmguero
Copy link
Collaborator Author

mmguero commented Nov 12, 2024

I need to test the hh-extracted-files proxying to hedgehog, then will close.

This was referenced Nov 14, 2024
Merged
Merged
@mmguero
Copy link
Collaborator Author

mmguero commented Nov 14, 2024

tested with hedgehog as well, closing

@mmguero mmguero closed this as completed Nov 14, 2024
@github-project-automation github-project-automation bot moved this from Testing to Done in Malcolm Nov 14, 2024
@mmguero mmguero moved this from Done to Released in Malcolm Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmguero mmguero

@jjrush jjrush

Labels
carving Relating to carving (extraction) of files from traffic and the scanning of those files enhancement New feature or request UI Relating to general UI experience
Projects
Malcolm
Status: Released
Milestone
v24.11.0
Development

No branches or pull requests
2 participants
@mmguero @jjrush