Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement paging for extracted files download dialog #595

Closed
mmguero opened this issue Oct 15, 2024 · 3 comments
Closed

implement paging for extracted files download dialog #595

mmguero opened this issue Oct 15, 2024 · 3 comments
Assignees
@jjrush
Labels
carving Relating to carving (extraction) of files from traffic and the scanning of those files enhancement New feature or request UI Relating to general UI experience
Milestone
v24.11.0

Comments

@mmguero
Copy link
Collaborator

mmguero commented Oct 15, 2024

We should implement paging in the extracted_files_http_server.py.

Pick something like a page size of 50 and have next/previous buttons at the bottom or top.
@mmguero mmguero added carving Relating to carving (extraction) of files from traffic and the scanning of those files enhancement New feature or request UI Relating to general UI experience labels Oct 15, 2024
@mmguero mmguero added this to the z.staging milestone Oct 15, 2024
@mmguero mmguero added this to Malcolm Oct 15, 2024
@mmguero mmguero moved this to Todo (develop) in Malcolm Oct 15, 2024
@mmguero mmguero modified the milestones: z.staging, v24.11.0 Oct 23, 2024
@jjrush
Copy link
Collaborator

jjrush commented Oct 24, 2024

I have this implemented and tested on a branch in my fork. Will work to get it added to a future release.

@mmguero
Copy link
Collaborator Author

mmguero commented Oct 24, 2024

I have this implemented and tested on a branch in my fork. Will work to get it added to a future release.

Thanks, just submit a PR to this repo and I'll get it staged for v24.11.0.

@mmguero mmguero moved this from Todo (develop) to In Progress in Malcolm Oct 24, 2024
This was referenced Oct 30, 2024
Closed
Merged
@mmguero mmguero mentioned this issue Nov 4, 2024
Closed
@mmguero
Copy link
Collaborator Author

mmguero commented Nov 4, 2024

Kamino closed and cloned this issue to cisagov/Malcolm

@mmguero mmguero closed this as completed Nov 4, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Malcolm Nov 4, 2024
@mmguero mmguero moved this from Done to Migrated in Malcolm Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jjrush jjrush

Labels
carving Relating to carving (extraction) of files from traffic and the scanning of those files enhancement New feature or request UI Relating to general UI experience
Projects
Malcolm
Status: Migrated
Milestone
v24.11.0
Development

No branches or pull requests
2 participants
@mmguero @jjrush