Replace env

cisagov · Dec 19, 2024 · 1c02f37 · 1c02f37
1 parent 23d0b07
commit 1c02f37
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/.github/workflows/build_sign_release.yaml b/.github/workflows/build_sign_release.yaml
@@ -12,7 +12,7 @@ on:
         type: string
       # Note: This is NOT the ACTUAL release version for ScubaGear.
       # That value is found in ScubaGear.psd1.
-      # This is only used for things like the file name.
+      # This is only used for things like the release file name.
       # Yes, this is a disconnect that violates DRY.
       version:
         description: "Release Version (e.g., 1.2.4)"
@@ -31,6 +31,7 @@ jobs:
     name: Build and Draft Release
     runs-on: windows-latest
     environment: Development
+    # TODO get rid of this env variable
     env:
       RELEASE_VERSION: ${{ inputs.version }}
     permissions:
@@ -51,8 +52,6 @@ jobs:
           # Source the function
           . repo/utils/workflow/Build-SignRelease.ps1
           Install-AzureSigningTool
-          # dotnet --version
-          # dotnet tool install --global AzureSignTool --version 5.0.0
       # OIDC Login to Azure Public Cloud with AzPowershell (enableAzPSSession true)
       - name: Login to Azure
         uses: azure/login@v2
@@ -63,10 +62,11 @@ jobs:
           enable-AzPSSession: true
       - name: Get Key Vault info
         id: key-vault-info
-        env:
-          KEY_VAULT_INFO: ${{ secrets.SCUBA_KEY_VAULT_PROD}}
+        # env:
+        #   KEY_VAULT_INFO: ${{ secrets.SCUBA_KEY_VAULT_PROD}}
         run: |
-          $KeyVaultInfo = ${env:KEY_VAULT_INFO} | ConvertFrom-Json
+          # $KeyVaultInfo = ${env:KEY_VAULT_INFO} | ConvertFrom-Json
+          $KeyVaultInfo = ${{ secrets.SCUBA_KEY_VAULT_PROD}} | ConvertFrom-Json
           echo "KeyVaultUrl=$($KeyVaultInfo.KeyVault.URL)" >> $env:GITHUB_OUTPUT
           echo "KeyVaultCertificateName=$($KeyVaultInfo.KeyVault.CertificateName)" >> $env:GITHUB_OUTPUT
       - name: Sign Module