Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow pipeline sometimes fails to fail #1454

Open
james-garriss opened this issue Dec 3, 2024 · 0 comments · May be fixed by #1470
Open

Workflow pipeline sometimes fails to fail #1454

james-garriss opened this issue Dec 3, 2024 · 0 comments · May be fixed by #1470
Assignees
Labels
bug This issue or pull request addresses broken functionality
Milestone

Comments

@james-garriss
Copy link
Collaborator

james-garriss commented Dec 3, 2024

🐛 Summary

Sometimes the workflow pipeline fails and annotations errors are present but the pipeline itself is all green and thus does not appear to be failing. This is misleading and could cause us to miss a problem.

To reproduce

Look here for examples:

https://github.com/cisagov/ScubaGear/actions/runs/12140173023
https://github.com/cisagov/ScubaGear/actions/runs/12125030421

Expected behavior

If there are annotation errors, then the pipeline itself should fail in one of its jobs/steps.

@james-garriss james-garriss added the bug This issue or pull request addresses broken functionality label Dec 3, 2024
@james-garriss james-garriss added this to the Lionfish milestone Dec 3, 2024
@james-garriss james-garriss self-assigned this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant