Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where Pester fails to run but workflow pipeline itself doesn't fail #1470

Open
wants to merge 160 commits into
base: main
Choose a base branch
from

Conversation

james-garriss
Copy link
Collaborator

@james-garriss james-garriss commented Dec 12, 2024

🗣 Description

💭 Motivation and context

Created function to call Pester and check results to verify that it actually ran. Created Pester tests for the function and called the function in various places.

🧪 Testing

Closes: #1454

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.

I had to change some files related to PR 1450 b/c these changes were messing with that workflow. Rebase and merge will harmonize everything.

  • These code changes follow the ScubaGear [content style guide]
  • Related issues these changes resolve are linked preferably via [closing keywords]
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • Unit tests added/updated to cover PowerShell and Rego changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.
  • Feature branch has been rebased against changes from parent branch, as needed
  • Resolved all merge conflicts on branch
  • Notified merge coordinator that PR is ready for merge via comment mention
  • Demonstrate changes to the team for questions and comments.

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@james-garriss james-garriss added the enhancement This issue or pull request will add new or improve existing functionality label Dec 12, 2024
@james-garriss james-garriss added this to the Lionfish milestone Dec 12, 2024
@james-garriss james-garriss self-assigned this Dec 12, 2024
@james-garriss james-garriss marked this pull request as ready for review December 19, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue or pull request will add new or improve existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow pipeline sometimes fails to fail
1 participant