Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore switching back our Run OPA tests action from back from < 0.50 to latest #593

Closed
1 task
buidav opened this issue Oct 12, 2023 · 2 comments · Fixed by #745
Closed
1 task

Explore switching back our Run OPA tests action from back from < 0.50 to latest #593

buidav opened this issue Oct 12, 2023 · 2 comments · Fixed by #745
Assignees
Labels
enhancement This issue or pull request will add new or improve existing functionality
Milestone

Comments

@buidav
Copy link
Collaborator

buidav commented Oct 12, 2023

💡 Summary

Back during the 0.30 release we had to switch the Run OPA tests workflow from latest to < .50 #193.
Over the course of the Emerald release, we've might've solved this issue with our Rego code updates.
This issue is to see if we can switch back from < .50 to latest.
run check

Motivation and context

To revert a change we made because we were out of compliance with OPA standards.

Implementation notes

Change that variable and see if our current rego code still fails.

Acceptance criteria

  • < 0.50 => latest in run_opa_tests.yaml
@buidav buidav added the enhancement This issue or pull request will add new or improve existing functionality label Oct 12, 2023
@buidav buidav added this to the Backlog milestone Oct 12, 2023
@buidav buidav changed the title Explore switching back our Run OPA tests action from < 0.50 to latest Explore switching back our Run OPA tests action from back from < 0.50 to latest Oct 12, 2023
@mitchelbaker-cisa
Copy link
Collaborator

Changing the OPA version from <0.50 to latest in run_opa_tests.yaml throws the same errors which are fixed in #631. Once this PR is merged then we should be fine switching the test action back to latest. (I pulled my changes from this PR to double check and the test action passes successfully)

Screenshot 2023-11-16 172417

@schrolla
Copy link
Collaborator

PR #631 has been merged to flipper branch, so this should be cleared to move ahead. Would also recommend updating the default expected version in the OPA.ps1 script to reference the latest version of the OPA engine by default so that version is downloaded on setup instead of the old version.

May need to wait/deconflict for PRs #197 to be merged to cleanly update the script version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue or pull request will add new or improve existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants