Revert run OPA tests action from <0.50 to latest #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchelbaker-cisa
added
the
enhancement
Sloane4
approved these changes
Dec 15, 2023
This was
linked to
issues
Dec 16, 2023
buidav
reviewed
Dec 18, 2023
There was a problem hiding this comment.
Need to update the number in this portion of the README as well. I noticed the significant revamp to the OPA.ps1. Out of scope for this issue but looks like that section need of the README needs a revamp as well now to match OPA.ps1 new capabilities.
TLDR: Update the OPA version number in the README at least. Update the README language there in another issue.
mitchelbaker-cisa
force-pushed
the
593-revert-opa-test-action
branch
from
2e97af0 to
660d503
Compare
buidav
approved these changes
Dec 19, 2023
james-garriss
pushed a commit
that referenced
this pull request
Dec 28, 2023
* under Run-OPA-Tests change OPA version from <0.50 to latest * bump expected version to v0.59.0 in OPA.ps1 * bump OPA expected version to 0.59.0 in SetUp.ps1 * update README.md with acceptable OPA version
mitchelbaker-cisa
added a commit
that referenced
this pull request
Jan 4, 2024
* under Run-OPA-Tests change OPA version from <0.50 to latest * bump expected version to v0.59.0 in OPA.ps1 * bump OPA expected version to 0.59.0 in SetUp.ps1 * update README.md with acceptable OPA version
schrolla
pushed a commit
that referenced
this pull request
Jan 19, 2024
* under Run-OPA-Tests change OPA version from <0.50 to latest * bump expected version to v0.59.0 in OPA.ps1 * bump OPA expected version to 0.59.0 in SetUp.ps1 * update README.md with acceptable OPA version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
run_opa_tests.ymlchanged OPA version from <0.50 to latestOPA.ps1/SetUp.ps1bump the expected version from v0.42.1 to v0.59.0💭 Motivation and context
During the 0.30 release the OPA version had to be switched from latest to <0.50, #193. PR #195 has been merged into Flipper which clears up the Rego errors preventing test actions from updating.
Resolves #196
Resolves #593
🧪 Testing
Download OPA v0.59.0 from https://www.openpolicyagent.org/docs/latest/.
./opa_windows_amd64.exe check Rego Testing/Unit/Rego -- strictInvoke-Scubacmdlet against all products for both gcc/gcchigh✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist