-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix circular reference between MS.EXO.16.1v1 and MS.DEFENDER.5.1v1 implementation instructions #1198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, requested a couple minor changes.
Unrelated to the changes in this PR, should we consider linking directly to respective admin consoles? i.e.
- Sign in to Microsoft 365 Defender.
#423 |
7705cf6
to
55ea497
Compare
Co-authored-by: mitchelbaker-cisa <149098823+mitchelbaker-cisa@users.noreply.github.com>
@nanda-katikaneni This PR is ready for merge. |
🗣 Description
Replicates list of activities from MS.EXO.16.1v1 to include when configuring M365 Defender alert policies as per MS.DEFENDER.5.1v1 implementation instructions.
💭 Motivation and context
Previously, readers would have to 'flip' between the two SCBs to follow Defender SCB implementation instructions while referencing Exchange Online alert policy activities list, then back to Defender to finish. Replicating the list from EXO in the Defender SCB eases the reader burden, makes the implementation instructions more standalone, while retaining the references between the two policy items for awareness.
Closes #565
🧪 Testing
This update only includes implementation instruction changes and does not change the contents or meaning of the policies themselves. Please review both MS.DEFENDER.5.1v1 and MS.EXO.16.1v1 SCBs (prior and proposed) to ensure the changes improve clarity and readability. Also recommend running through the MS.DEFENDER.5.1v1 implementation directly to validate usability.
✅ Pre-approval checklist
All relevant repo and/or project documentation updated to reflect these changes.(No doc updates required)Unit tests added/updated to cover PowerShell and Rego changes.(No code changes)Functional tests added/updated to cover PowerShell and Rego changes.(No code changes)✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branch
button below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
✅ Post-merge checklist