Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teams baseline updates for policies #2.2 and #3.1 to add notes #1219

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

nanda-katikaneni
Copy link
Collaborator

@nanda-katikaneni nanda-katikaneni commented Jul 17, 2024

🗣 Description

Add notes to MS.TEAMS.2.2 and MS.TEAMS.3.1 clarifying that the settings are not applicable for GCC, GCC High, or DOD tenants. Make the note consistent with existing note for the policy MS.TEAMS.2.3

💭 Motivation and context

closes #1069

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • These code changes follow the ScubaGear content style guide.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • Unit tests added/updated to cover PowerShell and Rego changes.
  • Functional tests added/updated to cover PowerShell and Rego changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@nanda-katikaneni nanda-katikaneni self-assigned this Jul 17, 2024
@nanda-katikaneni nanda-katikaneni added the baseline-document Issues relating to the text in the baseline documents themselves label Jul 17, 2024
@nanda-katikaneni nanda-katikaneni added this to the Iceberg milestone Jul 17, 2024
Copy link
Collaborator

@ahuynhMITRE ahuynhMITRE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no additional comments from me!

Copy link
Collaborator

@dagarwal-mitre dagarwal-mitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nanda-katikaneni nanda-katikaneni merged commit 7881690 into main Jul 18, 2024
23 checks passed
@nanda-katikaneni nanda-katikaneni deleted the 1069-teams-baseline-update branch July 18, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
baseline-document Issues relating to the text in the baseline documents themselves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify that unmanaged user / skype access is not available in GCC
3 participants