-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed Sharepoint policy 1.4 to not-implemented since it relies on deprecated field RequireAcceptingAccountMatchInvitedAccount #1270
Conversation
…eprecated field RequireAcceptingAccountMatchInvitedAccount
Testers please run ScubaGear with both interactive auth and service principal since we can to ensure Sharepoint works as expected with both. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested generating a report with interactive authentication with success; ran functional tests and the SharePoint 1.4 revisions for both spo/pnp passed as expected; smoke tests pass.
As a future TODO we should create an issue to track deletion of SharePoint 1.4 when the time comes. The task would require modifying removedpolicies.md.
@ahuynhMITRE Can u kindly take care of that? thank you much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran SPO and PNP tests. No problems.
@nanda-katikaneni ready for merge |
🗣 Description
Modified the implementation of Sharepoint 1.4 so that it is "not implemented" in the report since we now have evidence that it is deprecated or at least a user cannot configure it anymore.
Closes #1267
🧪 Testing
Tested using interactive authentication and service principal against the E5 tenant. Verified that the report produces the expected output message.
✅ Pre-approval checklist
✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branch
button below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
✅ Post-merge checklist