Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Sharepoint policy 1.4 to not-implemented since it relies on deprecated field RequireAcceptingAccountMatchInvitedAccount #1270

Conversation

tkol2022
Copy link
Collaborator

@tkol2022 tkol2022 commented Aug 8, 2024

🗣 Description

Modified the implementation of Sharepoint 1.4 so that it is "not implemented" in the report since we now have evidence that it is deprecated or at least a user cannot configure it anymore.

Closes #1267

🧪 Testing

Tested using interactive authentication and service principal against the E5 tenant. Verified that the report produces the expected output message.

image

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • These code changes follow the ScubaGear content style guide.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • Unit tests added/updated to cover PowerShell and Rego changes.
  • Functional tests added/updated to cover PowerShell and Rego changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

…eprecated field RequireAcceptingAccountMatchInvitedAccount
@tkol2022 tkol2022 added the bug This issue or pull request addresses broken functionality label Aug 8, 2024
@tkol2022 tkol2022 self-assigned this Aug 8, 2024
@schrolla schrolla added this to the Iceberg milestone Aug 8, 2024
@tkol2022
Copy link
Collaborator Author

tkol2022 commented Aug 8, 2024

Testers please run ScubaGear with both interactive auth and service principal since we can to ensure Sharepoint works as expected with both.

Copy link
Collaborator

@mitchelbaker-cisa mitchelbaker-cisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested generating a report with interactive authentication with success; ran functional tests and the SharePoint 1.4 revisions for both spo/pnp passed as expected; smoke tests pass.

As a future TODO we should create an issue to track deletion of SharePoint 1.4 when the time comes. The task would require modifying removedpolicies.md.

@tkol2022
Copy link
Collaborator Author

tkol2022 commented Aug 9, 2024

Tested generating a report with interactive authentication with success; ran functional tests and the SharePoint 1.4 revisions for both spo/pnp passed as expected; smoke tests pass.

As a future TODO we should create an issue to track deletion of SharePoint 1.4 when the time comes. The task would require modifying removedpolicies.md.

@ahuynhMITRE Can u kindly take care of that? thank you much.

Copy link
Collaborator

@james-garriss james-garriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran SPO and PNP tests. No problems.

@tkol2022
Copy link
Collaborator Author

@nanda-katikaneni ready for merge

@nanda-katikaneni nanda-katikaneni merged commit a66e4df into main Aug 12, 2024
26 checks passed
@nanda-katikaneni nanda-katikaneni deleted the 1267-sharepoint-14-acceptingaccountmatchinvitedaccount-deprecated branch August 12, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sharepoint policy 1.4 setting RequireAcceptingAccountMatchInvitedAccount seems to be deprecated or ignored
5 participants