-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct Erroring Default Variable Assignments on Systems with unique file paths #1387
Correct Erroring Default Variable Assignments on Systems with unique file paths #1387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good. Tested on a Windows, changes don't break default behavior (as expected). Deferring to @amart241 to test on a Mac.
I tested this successfully on a Mac. Worked after manually installing the executable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successful test when manually downloading opa. Didn't use Install-OPAforSCuBA which seems to use a different filename (opa_darwin_amd64) but that's likely a separate issue.
ebe61c6
to
eddea69
Compare
@nanda-katikaneni this is ready to merge |
🗣 Description
DefaultOutPath
work on UNC file systems.DefaultOPAPath
assignment.💭 Motivation and context
Closes #1315
Closes #1369
🧪 Testing
Import-Module .\PowerShell\ScubaGear
on a non-Windows system.Import-Module .\PowerShell\ScubaGear
on system using UNC file paths.✅ Pre-approval checklist
singlerelated goals ;) - eschew scope creep!✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branch
button below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
✅ Post-merge checklist