-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Users to Specify Installing to AllUsers via new $Scope Variable in Initialize-SCuBA #1388
Allow Users to Specify Installing to AllUsers via new $Scope Variable in Initialize-SCuBA #1388
Conversation
@buidav Can you kindly provide some specific testing guidance on how to test the -Scope AllUsers option? For example, after I execute it, where do I check to ensure it completed as expected? |
This is meant for systems with multiple users. User1 and User2. |
Thanks. It sounds like we need to test on a virtual machine. Please review my testing steps below and update them if necessary. Testing Steps
|
Looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected. Testing I performed:
- Create 3 users on a VM: Alice, Bob, and an admin account.
- Run
Initialize-Scuba
as normal as Alice. Alice now has the required PowerShell modules, as expected. - Login as Bob. Bob still does not have the required PowerShell modules, as expected.
- Login as the admin. Run
Initialize-Scuba -Scope AllUsers
. The admin now has the required PowerShell modules, as expected. - Login as Bob. Bob now has the required PowerShell modules, as expected.
One suggestion would be to document this feature in the README, perhaps near the top of the Dependencies page. Something like "Note: the Initialize-SCuBA
cmdlet can optionally install the required modules system-wide, if run as an administrator with -Scope AllUsers
." Not essential, approving either way.
7b912b6
to
94de1d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the code looks good!
@nanda-katikaneni this is ready to merge. |
🗣 Description
$Scope
to Initialize-SCuBA to let users install toAllUsers
, a place where all users can access the dependent PowerShell modules, rather than just theCurrentUser
on their system.💭 Motivation and context
Closes #882
🧪 Testing
Initalize-SCuBA
by itself. Should be the normal behavior.Initialize-SCuBA -Scope AllUsers
.✅ Pre-approval checklist
✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branch
button below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
✅ Post-merge checklist