-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove extraneous SHALL from MS.DEFENDER.4.1 #1408
Remove extraneous SHALL from MS.DEFENDER.4.1 #1408
Conversation
f02e775
to
d27dffc
Compare
…sults JSON output
d27dffc
to
39a1ceb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to also update MS.DEFENDER.4.1 version in the defender.testplan.yaml
Good catch. I've updated to v2 in all the 4.1 functional test plan entries, both the PolicyId and the Test Description blocks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@nanda-katikaneni This PR is ready for merge. |
🗣 Description
The Defender SCB policy MS.DEFENDER.4.1v1 was reworded without changing the policy meaning so that it contains a single SHALL statement rather than two SHALLs for clarity. In addition, since the policy language was changed, the policy ID was incremented from v1 to v2. Policy version updates were made to the following:
💭 Motivation and context
Baselines should contain a single SHALL/SHOULD statement per policy so that a single testable policy item is associated with each statement and to prevent confusion among readers.
Closes #1385
🧪 Testing
To verify that all appropriate references have been updated:
Invoke-Scuba -p defender
to confirm proper HTML generation and review all automated test results.✅ Pre-approval checklist
✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branch
button below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
Demonstrate changes to the team for questions and comments.
(Note: Only required for issues of size
Medium
or larger)✅ Post-merge checklist