-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert baseline markdown files to text and HTML #1435
Convert baseline markdown files to text and HTML #1435
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Wish there was a way to for loop this somehow but doing that in this workflow would be adding unnecessary abstraction.
Since, we don't change the baseline document names/locations often.
I don't disagree with the idea of a loop, @buidav , but given that we don't really understand what Drupal needs at this point, I was reluctant to spend more time on this task. I will put this on my personal backlog. If/when we get clarification, I will look at moving this into code (.ps1 function), where we can use a loop and add unit testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified html/text files from output and looks good.
b3fcfd3
to
f8d3fbc
Compare
🗣 Description
This PR converts the existing baseline files that are in Markdown to both HTML and text format. It saves them to the baselines folder and then makes that folder available as an artifact.
💭 Motivation and context
Closes: #1376
🧪 Testing
Wrote and tested original workflow in an alternate repository.
Once workflow was working, moved to SG repo and modified accordingly.
Verified expected results were found in the artifact.
✅ Pre-approval checklist
✅ Pre-merge checklist
✅ Post-merge checklist