Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tests for MS.AAD.5.4v1 for teams group consent to not-implemented as setting is deprecated #1460

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

rmoffitt-m
Copy link
Collaborator

@rmoffitt-m rmoffitt-m commented Dec 6, 2024

🗣 Description

Update rego for MS.AAD.5.4v1 to not-implemented as the group consent setting is discontinued.
In case the setting is not discontinued in other Azure implementations (e.g. GCC), the rule will continue to function as expected.

💭 Motivation and context

Changes the tests to not-implemented to avoid falsely failing a test that can no longer be performed. The baseline can be removed in a future release.
Closes #1139

🧪 Testing

Run AAD tests and verify that the test result for MS.AAD.5.4v1 is N/A instead of failed and criticality is not-implemented. Ensure tests can still successfully run.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • These code changes follow the ScubaGear content style guide.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • Unit tests added/updated to cover PowerShell and Rego changes.
  • Functional tests added/updated to cover PowerShell and Rego changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

  • Demonstrate changes to the team for questions and comments.
    (Note: Only required for issues of size Medium or larger)

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@rmoffitt-m rmoffitt-m added the microsoft roadmap Issues relating to Microsoft's roadmap. label Dec 6, 2024
@rmoffitt-m rmoffitt-m self-assigned this Dec 6, 2024
@rmoffitt-m rmoffitt-m linked an issue Dec 6, 2024 that may be closed by this pull request
@rmoffitt-m rmoffitt-m marked this pull request as ready for review December 7, 2024 02:23
Copy link
Collaborator

@schrolla schrolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the updated Rego code and it is consistent with other deprecated setting changes. The HTML report shows 5.4 as N/A and deprecated as does the JSON showing as Shall/Not-Implemented.
Unit tests pass.
Functional test for AAD 5.4 does not pass. Currently it fails with an error indicating an issue running the test. Also found issues with the configuration of the functional test itself. See comments and recommended changes below to resolve.

Testing/Functional/Products/TestPlans/aad.testplan.yaml Outdated Show resolved Hide resolved
Testing/Functional/Products/TestPlans/aad.testplan.yaml Outdated Show resolved Hide resolved
@schrolla schrolla added this to the Kraken milestone Dec 11, 2024
Copy link
Collaborator

@schrolla schrolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest commit addresses the failed functional test issues previously noted. Looks good.

Copy link
Collaborator

@ahuynhMITRE ahuynhMITRE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new results consistent with other not implemented policies. Create a new issue for the removal of the setting from the SCB set for the "m" release milestone with a reference to this PR and issue!

@tkol2022
Copy link
Collaborator

Nice work Rich. Seems to match up with other deprecations we have incorporated before.

@rmoffitt-m
Copy link
Collaborator Author

Created new issue to update baseline to wrap up todos for this issue. No rebase required for successful merge.

@rmoffitt-m rmoffitt-m force-pushed the 1139-msaad54v1-teamsgroupconsent-deprecated branch from 990e3b8 to 7d65d00 Compare December 17, 2024 21:31
@rmoffitt-m
Copy link
Collaborator Author

rebased and all checks passed. ready for merge @nanda-katikaneni

@nanda-katikaneni nanda-katikaneni merged commit 73f9721 into main Dec 17, 2024
27 checks passed
@nanda-katikaneni nanda-katikaneni deleted the 1139-msaad54v1-teamsgroupconsent-deprecated branch December 17, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
microsoft roadmap Issues relating to Microsoft's roadmap.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MS.AAD.5.4v1 setting discontinued by Microsoft
5 participants