-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change tests for MS.AAD.5.4v1 for teams group consent to not-implemented as setting is deprecated #1460
Change tests for MS.AAD.5.4v1 for teams group consent to not-implemented as setting is deprecated #1460
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the updated Rego code and it is consistent with other deprecated setting changes. The HTML report shows 5.4 as N/A and deprecated as does the JSON showing as Shall/Not-Implemented.
Unit tests pass.
Functional test for AAD 5.4 does not pass. Currently it fails with an error indicating an issue running the test. Also found issues with the configuration of the functional test itself. See comments and recommended changes below to resolve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest commit addresses the failed functional test issues previously noted. Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new results consistent with other not implemented policies. Create a new issue for the removal of the setting from the SCB set for the "m" release milestone with a reference to this PR and issue!
Nice work Rich. Seems to match up with other deprecations we have incorporated before. |
Created new issue to update baseline to wrap up todos for this issue. No rebase required for successful merge. |
990e3b8
to
7d65d00
Compare
rebased and all checks passed. ready for merge @nanda-katikaneni |
🗣 Description
Update rego for MS.AAD.5.4v1 to not-implemented as the group consent setting is discontinued.
In case the setting is not discontinued in other Azure implementations (e.g. GCC), the rule will continue to function as expected.
💭 Motivation and context
Changes the tests to not-implemented to avoid falsely failing a test that can no longer be performed. The baseline can be removed in a future release.
Closes #1139
🧪 Testing
Run AAD tests and verify that the test result for MS.AAD.5.4v1 is N/A instead of failed and criticality is not-implemented. Ensure tests can still successfully run.
✅ Pre-approval checklist
✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branch
button below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
Demonstrate changes to the team for questions and comments.
(Note: Only required for issues of size
Medium
or larger)✅ Post-merge checklist