-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjudicate substantive changes to the powerbi baseline markdown following the new format #403
Adjudicate substantive changes to the powerbi baseline markdown following the new format #403
Conversation
0356862
to
225b2b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree with David's comments and main comment from me was re-adding the "shall" and "should" language into each of the policies.
225b2b1
to
3b080c8
Compare
8efcfcb
to
4c565f7
Compare
some comments:
This section helps reduce security risks related to [Policy Group]. This includes [Scope of policies ] (This sentence is as needed).
|
The current rationale format follows what AAD and Defender are using. Would we have to refactor the rationale format for those baselines as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and adjudicated my comments directly with Alex.
I have removed a total of 3 policies from the Power BI baseline. I most recently removed the logging related policy because it is inconsistent across the new "fabric" and current Power BI, it also requires and Azure subscription. #315 were the other 2 policies that I removed. |
"1. Publish to Web If it is deemed necessary to make an exception and enable the feature, admins should limit the ability to publish to the web to only specific security groups, instead of allowing the entire agency to publish data to the web." This would be updated to the following: This section helps reduce security risks related to Power Bi's capability to publish to the web. " This was a note by Ted since a lot of the text will be covered by the rationale and is inconsistent across baselines. |
Will have to bring this up for group discussion then because I don't remember us have an item/task for standardizing the text at the top level of each policy groups. |
good point, will add as a parking lot item for tomorrow. Probably lost in the many conversations / reviews over the past months and open to whatever works best. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good after the discussion at the stand up!
@nanda-katikaneni ready to merge |
updated to newest format, removed should and shall wording, new style for implementation
Addressed comments on pull request for this branch.
additional formatting to the baseline
more formatting and removal of one baseline
more updates
More formatting
one change
more formatting
f880219
to
15d6b79
Compare
…wing the new format (#403) * Update powerbi.md * Update powerbi.md * Update powerbi.md updated to newest format, removed should and shall wording, new style for implementation * Update powerbi.md Addressed comments on pull request for this branch. * Update powerbi.md additional formatting to the baseline * Update powerbi.md more formatting and removal of one baseline * Update powerbi.md more updates * Update powerbi.md More formatting * Update powerbi.md one change * Update powerbi.md more formatting
…wing the new format (#403) * Update powerbi.md * Update powerbi.md * Update powerbi.md updated to newest format, removed should and shall wording, new style for implementation * Update powerbi.md Addressed comments on pull request for this branch. * Update powerbi.md additional formatting to the baseline * Update powerbi.md more formatting and removal of one baseline * Update powerbi.md more updates * Update powerbi.md More formatting * Update powerbi.md one change * Update powerbi.md more formatting
…wing the new format (#403) * Update powerbi.md * Update powerbi.md * Update powerbi.md updated to newest format, removed should and shall wording, new style for implementation * Update powerbi.md Addressed comments on pull request for this branch. * Update powerbi.md additional formatting to the baseline * Update powerbi.md more formatting and removal of one baseline * Update powerbi.md more updates * Update powerbi.md More formatting * Update powerbi.md one change * Update powerbi.md more formatting
…wing the new format (#403) * Update powerbi.md * Update powerbi.md * Update powerbi.md updated to newest format, removed should and shall wording, new style for implementation * Update powerbi.md Addressed comments on pull request for this branch. * Update powerbi.md additional formatting to the baseline * Update powerbi.md more formatting and removal of one baseline * Update powerbi.md more updates * Update powerbi.md More formatting * Update powerbi.md one change * Update powerbi.md more formatting
🗣 Description
Changed formatting and content of PowerBI baseline to match new formatting structure
💭 Motivation and context
Consolidated format and clearer to read and understand layout
🧪 Testing
N/A
✅ Pre-approval checklist
✅ Pre-merge checklist
✅ Post-merge checklist