Update unit test script #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianjburgos
added
the
bug
Sloane4
requested changes
Jul 17, 2023
schrolla
force-pushed
the
update-unit-test
branch
from
14892ab to
f40949e
Compare
julianjburgos
force-pushed
the
update-unit-test
branch
from
f40949e to
a241cc5
Compare
added 4 commits
July 18, 2023 11:13
placed in left side of equality on line 132
schrolla
force-pushed
the
update-unit-test
branch
from
a241cc5 to
e171830
Compare
schrolla
requested changes
Jul 18, 2023
schrolla
approved these changes
Jul 20, 2023
Sloane4
approved these changes
Jul 20, 2023
crutchfield
pushed a commit
that referenced
this pull request
Aug 23, 2023
* Fixed hardcoded naming bug and created warning msg * Small syntax issue that did not affect the code was fixed. Null was placed in left side of equality on line 132 * Fixed trailing whitespace * Fixed -b to -c * Removed -h option --------- Co-authored-by: Julian Burgos <JBURGOS@MITRE.ORG>
schrolla
pushed a commit
that referenced
this pull request
Sep 1, 2023
* Fixed hardcoded naming bug and created warning msg * Small syntax issue that did not affect the code was fixed. Null was placed in left side of equality on line 132 * Fixed trailing whitespace * Fixed -b to -c * Removed -h option --------- Co-authored-by: Julian Burgos <JBURGOS@MITRE.ORG>
schrolla
pushed a commit
that referenced
this pull request
Nov 2, 2023
* Fixed hardcoded naming bug and created warning msg * Small syntax issue that did not affect the code was fixed. Null was placed in left side of equality on line 132 * Fixed trailing whitespace * Fixed -b to -c * Removed -h option --------- Co-authored-by: Julian Burgos <JBURGOS@MITRE.ORG>
schrolla
pushed a commit
that referenced
this pull request
Nov 2, 2023
* Fixed hardcoded naming bug and created warning msg * Small syntax issue that did not affect the code was fixed. Null was placed in left side of equality on line 132 * Fixed trailing whitespace * Fixed -b to -c * Removed -h option --------- Co-authored-by: Julian Burgos <JBURGOS@MITRE.ORG>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Updated RunUnitTest script that were broken by updated baselines.
💭 Motivation and context
Due to the change of baseline names, the PowerShell script was unable to properly run to test each individual unit test. There was also an issue where test names within each control group that did not exist but were specified with the -t option would pass. This was resolved where a warning would appear if a test name did not exist.
🧪 Testing
I tested the changes made by testing each product individually as well as calling individual baseline test numbers to ensure that the script is supposed to run as intended. I also tested if a specific baseline that was specified did not exist as well as if a test within the specific baseline did not exist.
Others can test by running:
ScubaGear\Testing\RunUnitTests.ps1 -p <product name(s)> -b <baseline number> -t <specific test case within baseline number>✅ Pre-approval checklist
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist