Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Exo Rego Code #662

Merged
merged 11 commits into from
Dec 13, 2023
Merged

Refactor Exo Rego Code #662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e24611a
first round of cleanup
Sloane4 Nov 6, 2023
8bb2e0a
create helper funtion for conditions filter code
Sloane4 Nov 6, 2023
dd3919f
add comments pt 1
Sloane4 Nov 10, 2023
ad09130
update syntax for constant
Sloane4 Nov 28, 2023
fe18d13
update for test package
Sloane4 Nov 28, 2023
e42ec00
fix policy indicated comments
Sloane4 Nov 30, 2023
ff637d3
fix json formatting & rego formatting
Sloane4 Dec 1, 2023
bdc6413
refactor out duplicate code in tests
Sloane4 Dec 4, 2023
6e757ce
remove unused imports
Sloane4 Dec 7, 2023
4fbce58
remove unused var
Sloane4 Dec 7, 2023
6c2f63f
remove constant
Sloane4 Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
969 changes: 553 additions & 416 deletions Rego/EXOConfig.rego
View file
Open in desktop

Large diffs are not rendered by default.

95 changes: 48 additions & 47 deletions Testing/Unit/Rego/EXO/EXOConfig_01_test.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,94 +1,95 @@
package exo
package exo_test
import future.keywords
import data.exo
import data.report.utils.ReportDetailsBoolean


CorrectTestResult(PolicyId, Output, ReportDetailString) := true if {
RuleOutput := [Result | some Result in Output; Result.PolicyId == PolicyId]

count(RuleOutput) == 1
RuleOutput[0].RequirementMet == true
RuleOutput[0].ReportDetails == ReportDetailString
} else := false

IncorrectTestResult(PolicyId, Output, ReportDetailString) := true if {
RuleOutput := [Result | some Result in Output; Result.PolicyId == PolicyId]

count(RuleOutput) == 1
RuleOutput[0].RequirementMet == false
RuleOutput[0].ReportDetails == ReportDetailString
} else := false

PASS := ReportDetailsBoolean(true)


#
# Policy 1
#--
test_AutoForwardEnabled_Correct if {
PolicyId := "MS.EXO.1.1v1"

Output := tests with input as {
Output := exo.tests with input as {
"remote_domains": [
{
"AutoForwardEnabled" : false,
"DomainName" : "Test name"
"AutoForwardEnabled": false,
"DomainName": "Test name"
}
]
}

RuleOutput := [Result | Result = Output[_]; Result.PolicyId == PolicyId]

count(RuleOutput) == 1
RuleOutput[0].RequirementMet
RuleOutput[0].ReportDetails == "Requirement met"
CorrectTestResult("MS.EXO.1.1v1", Output, PASS) == true
}

test_AutoForwardEnabled_Incorrect_V1 if {
PolicyId := "MS.EXO.1.1v1"

Output := tests with input as {
Output := exo.tests with input as {
"remote_domains": [
{
"AutoForwardEnabled" : true,
"DomainName" : "Test name"
"AutoForwardEnabled": true,
"DomainName": "Test name"
}
]
}

RuleOutput := [Result | Result = Output[_]; Result.PolicyId == PolicyId]

count(RuleOutput) == 1
not RuleOutput[0].RequirementMet
RuleOutput[0].ReportDetails == "1 remote domain(s) that allows automatic forwarding: Test name"
ReportDetailString := "1 remote domain(s) that allows automatic forwarding: Test name"
IncorrectTestResult("MS.EXO.1.1v1", Output, ReportDetailString) == true
}

test_AutoForwardEnabled_Incorrect_V2 if {
PolicyId := "MS.EXO.1.1v1"

Output := tests with input as {
Output := exo.tests with input as {
"remote_domains": [
{
"AutoForwardEnabled" : true,
"DomainName" : "Test name"
"AutoForwardEnabled": true,
"DomainName": "Test name"
},
{
"AutoForwardEnabled" : true,
"DomainName" : "Test name 2"
"AutoForwardEnabled": true,
"DomainName": "Test name 2"
}
]
}

RuleOutput := [Result | Result = Output[_]; Result.PolicyId == PolicyId]

count(RuleOutput) == 1
not RuleOutput[0].RequirementMet
RuleOutput[0].ReportDetails == "2 remote domain(s) that allows automatic forwarding: Test name, Test name 2"
ReportDetailString := "2 remote domain(s) that allows automatic forwarding: Test name, Test name 2"
IncorrectTestResult("MS.EXO.1.1v1", Output, ReportDetailString) == true
}

test_AutoForwardEnabled_Incorrect_V3 if {
PolicyId := "MS.EXO.1.1v1"

Output := tests with input as {
Output := exo.tests with input as {
"remote_domains": [
{
"AutoForwardEnabled" : true,
"DomainName" : "Test name"
"AutoForwardEnabled": true,
"DomainName": "Test name"
},
{
"AutoForwardEnabled" : true,
"DomainName" : "Test name 2"
"AutoForwardEnabled": true,
"DomainName": "Test name 2"
},
{
"AutoForwardEnabled" : false,
"DomainName" : "Test name 3"
"AutoForwardEnabled": false,
"DomainName": "Test name 3"
}
]
}

RuleOutput := [Result | Result = Output[_]; Result.PolicyId == PolicyId]

count(RuleOutput) == 1
not RuleOutput[0].RequirementMet
RuleOutput[0].ReportDetails == "2 remote domain(s) that allows automatic forwarding: Test name, Test name 2"
ReportDetailString := "2 remote domain(s) that allows automatic forwarding: Test name, Test name 2"
IncorrectTestResult("MS.EXO.1.1v1", Output, ReportDetailString) == true
}
#--
Loading