-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added criticality to Power BI Markdown #690
Added criticality to Power BI Markdown #690
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All 8 policy Criticality tags all conform to the format regex:
<--Policy: MS.POWERBI.\d\.\dv1; Criticality: SHOULD -->
So no misspellings or format variations, and exactly 8 matches found in the baseline.
Verified that all policies have a matching criticality and policy ID relevant to the policy scope in which they are shown.
Looks good. Only question is does this go in v1.0.0 (main) or flipper? Currently, it's targeted at main so defaulting to v1.0.0.
fine with either since it will not affect the code at this time. Any reason not to put it in main / v1.0.0? |
Slightly more complex rebase/merge semantics since we already split the flipper branch. I results in a rebase cascade (rebase flipper base branch, then rebase of feature branches targetting flipper). This two level rebase can lead to issues, particularly for large PRs. And several of the rego PRs are wide ranging in the files touched. So, while I understand wanting to put it in v1.0.0 since it is more a consistency change with no visible or functional impact, I'd recommend just letting it squeak into flipper instead. All good with me, will update the base to the flipper branch! |
good to merge @nanda-katikaneni |
@ahuynhMITRE - will merge this into flipper; please change the milestone for the associated issue #689 to flipper (its currently in emerald). |
Noticed this as well and updated it this morning. Probably didn't refresh on your page @nanda-katikaneni if you already had it up at the time of review. Set for Flipper Sprint 1 milestone now. |
commit ff766d5 Author: Cassandra Diaz <47129205+Sloane4@users.noreply.github.com> Date: Wed Dec 13 18:03:26 2023 -0500 Refactor Exo Rego Code (#662) * first round of cleanup first round of cleanup * create helper funtion for conditions filter code create helper funtion for conditions filter code * add comments pt 1 add comments pt 1 add comments pt 2 add comments pt 2 * update syntax for constant update syntax for constant * update for test package update for test package * fix policy indicated comments fix policy indicated comments * fix json formatting & rego formatting fix json formatting & rego formatting * refactor out duplicate code in tests refactor out duplicate code in tests * remove unused imports remove unused imports * remove unused var remove unused var * remove constant commit d5cb929 Author: Cassandra Diaz <47129205+Sloane4@users.noreply.github.com> Date: Wed Dec 13 15:50:14 2023 -0500 Refactor Defender Rego Code (#663) * first round of cleanup * update for test package * fix policy spaces * fix json formatting & unfixed unit tests * refactor out duplicate code in test cases * refactor out OR checking duplicate code * add comments * add constants * add set comprehension to method call commit 29536fe Author: Cassandra Diaz <47129205+Sloane4@users.noreply.github.com> Date: Wed Dec 13 15:49:31 2023 -0500 Refactor AAD Rego Code (#664) * first round of cleanup * update for test package * update for constants * fix json formatting * remove extra newline * refactor out duplicate code in tests * add comments part 1 add comments part 2 * fix test cases * fix based on some comments commit f7cd368 Author: Richard Crutchfield <crutchfield@users.noreply.github.com> Date: Wed Dec 13 15:14:28 2023 -0500 Smoke test periodically fails (#728) * Rework download logic * Fix file path * Fix clean up * Update Testing/Functional/SmokeTest/UpdateSelenium.ps1 Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Add error action to download --------- Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> commit 883815c Author: Cassandra Diaz <47129205+Sloane4@users.noreply.github.com> Date: Wed Dec 13 09:10:32 2023 -0500 Refactor Teams Rego Code (#660) * first round of cleanup * address line length & rule length warnings. Also refactor duplicate code & constants * default over else line 413 * cleanup * add spacing * add comments * fix line length * update for test package * fix spacing * fix policy indicated comments * refactor out duplicate code in test cases * fix json formatting * remove unused var * Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * update var name --------- Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> commit e623c92 Author: Cassandra Diaz <47129205+Sloane4@users.noreply.github.com> Date: Wed Dec 13 09:10:00 2023 -0500 Refactor Power Platform (#661) * first round of cleanup * create helper funtion for conditions filter code * add comments * update for test package * fix policy indicated comments * fix json formatting & rego formatting * refactor out duplicate code in test cases * Update Rego/PowerPlatformConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/PowerPlatformConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/PowerPlatformConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> --------- Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> commit d88a16e Author: Cassandra Diaz <47129205+Sloane4@users.noreply.github.com> Date: Tue Dec 12 20:22:17 2023 -0500 Refactor Sharepoint Rego Code (#659) * add constants & reduce line lengths * removed unnecessary commas * create helper funtion for conditions filter code * add newline between constants * address line length & rule length warnings * add comments * add comments * removed top level iteration * cleanup * update for test package * remove extra newline * fix boolean compare in unit tests * create constants for sharing settings * add naming convention for test package * remove extra space at end of file * fix json format * fix package naming pattern * fix policy indicated comments * refactor out duplicate code in test cases * remove unused var commit a5a679a Author: Dylan Gao <107067015+Dylan-MITRE@users.noreply.github.com> Date: Mon Dec 11 14:38:00 2023 -0500 add progress bar for OPA download (#682) * Update OPA.ps1 * Update OPA.ps1 * remove white space and requirement * Update OPA.ps1 revert to bit transfer and detailed error messages commit 8698efb Author: Richard Crutchfield <crutchfield@users.noreply.github.com> Date: Mon Dec 11 14:36:48 2023 -0500 Breaking dependency on opa in unit testing (#721) * Mock opa executable * Mock API Module * Add NoOpa to setup call * Backout unrelated change commit fe743e1 Author: Richard Crutchfield <crutchfield@users.noreply.github.com> Date: Mon Dec 11 13:34:37 2023 -0500 Remove PnP work-around (#725) commit 2b2b729 Author: mitchelbaker-cisa <149098823+mitchelbaker-cisa@users.noreply.github.com> Date: Mon Dec 11 09:09:34 2023 -0800 update unused variables to wildcards in DefenderConfig.rego, EXOConfig.rego, PowerPlatformConfig.rego, TeamsConfig.rego, ReportUtils.rego (up to v0.51.0) (#631) commit 2b4bb8e Author: Cassandra Diaz <47129205+Sloane4@users.noreply.github.com> Date: Thu Dec 7 16:33:40 2023 -0500 Download OPA only when required & Print real error message (#641) * Download only when needed & print real error * removed unneeded comment * added ability to take parameter input & removed hardcoded hash * cleanup * get hash from .sha256 file * update to check from acceptable version * add function to install opa for other os * update help message * Update OPA.ps1 Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update OPA.ps1 Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update OPA.ps1 Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update OPA.ps1 Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update SetUp.ps1 Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update OPA.ps1 Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * edge case fix * prevent user from accidently overwiting personal file --------- Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> commit bbb6c86 Author: James Garriss <52328727+james-garriss@users.noreply.github.com> Date: Wed Dec 6 10:21:52 2023 -0500 updated checkout action version (#692) * updated checkout action version * update checkout to v4 --------- Co-authored-by: James Garriss <jgarriss@mitre.org> commit 5016111 Author: David Bui <105074908+buidav@users.noreply.github.com> Date: Tue Dec 5 09:28:30 2023 -0800 add -UseBasicParsing to Invoke-WebRequest (#695) commit 7a11343 Author: Cassandra Diaz <47129205+Sloane4@users.noreply.github.com> Date: Tue Nov 28 11:14:14 2023 -0500 Address Rego Linter (Regal) Rules (#640) * Change ignore to warning for specified rules in issue * update style guide for new linter rules * change to warning for test-outside-test-package and rule-length * Update .regal/config.yaml Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update .regal/config.yaml Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update CONTENTSTYLEGUIDE.md Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update CONTENTSTYLEGUIDE.md Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * updated opa rego intro paragraph * removed extra sentance * removed bulletpoint * fix capitalization * add punctuation * word smithing * Update CONTENTSTYLEGUIDE.md Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> --------- Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> commit 8e46600 Author: Andrew Huynh <113476170+ahuynhMITRE@users.noreply.github.com> Date: Mon Nov 27 10:38:45 2023 -0500 added critcality (#690)
commit ff766d5 Author: Cassandra Diaz <47129205+Sloane4@users.noreply.github.com> Date: Wed Dec 13 18:03:26 2023 -0500 Refactor Exo Rego Code (#662) * first round of cleanup first round of cleanup * create helper funtion for conditions filter code create helper funtion for conditions filter code * add comments pt 1 add comments pt 1 add comments pt 2 add comments pt 2 * update syntax for constant update syntax for constant * update for test package update for test package * fix policy indicated comments fix policy indicated comments * fix json formatting & rego formatting fix json formatting & rego formatting * refactor out duplicate code in tests refactor out duplicate code in tests * remove unused imports remove unused imports * remove unused var remove unused var * remove constant commit d5cb929 Author: Cassandra Diaz <47129205+Sloane4@users.noreply.github.com> Date: Wed Dec 13 15:50:14 2023 -0500 Refactor Defender Rego Code (#663) * first round of cleanup * update for test package * fix policy spaces * fix json formatting & unfixed unit tests * refactor out duplicate code in test cases * refactor out OR checking duplicate code * add comments * add constants * add set comprehension to method call commit 29536fe Author: Cassandra Diaz <47129205+Sloane4@users.noreply.github.com> Date: Wed Dec 13 15:49:31 2023 -0500 Refactor AAD Rego Code (#664) * first round of cleanup * update for test package * update for constants * fix json formatting * remove extra newline * refactor out duplicate code in tests * add comments part 1 add comments part 2 * fix test cases * fix based on some comments commit f7cd368 Author: Richard Crutchfield <crutchfield@users.noreply.github.com> Date: Wed Dec 13 15:14:28 2023 -0500 Smoke test periodically fails (#728) * Rework download logic * Fix file path * Fix clean up * Update Testing/Functional/SmokeTest/UpdateSelenium.ps1 Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Add error action to download --------- Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> commit 883815c Author: Cassandra Diaz <47129205+Sloane4@users.noreply.github.com> Date: Wed Dec 13 09:10:32 2023 -0500 Refactor Teams Rego Code (#660) * first round of cleanup * address line length & rule length warnings. Also refactor duplicate code & constants * default over else line 413 * cleanup * add spacing * add comments * fix line length * update for test package * fix spacing * fix policy indicated comments * refactor out duplicate code in test cases * fix json formatting * remove unused var * Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * update var name --------- Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> commit e623c92 Author: Cassandra Diaz <47129205+Sloane4@users.noreply.github.com> Date: Wed Dec 13 09:10:00 2023 -0500 Refactor Power Platform (#661) * first round of cleanup * create helper funtion for conditions filter code * add comments * update for test package * fix policy indicated comments * fix json formatting & rego formatting * refactor out duplicate code in test cases * Update Rego/PowerPlatformConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/PowerPlatformConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/PowerPlatformConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> --------- Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> commit d88a16e Author: Cassandra Diaz <47129205+Sloane4@users.noreply.github.com> Date: Tue Dec 12 20:22:17 2023 -0500 Refactor Sharepoint Rego Code (#659) * add constants & reduce line lengths * removed unnecessary commas * create helper funtion for conditions filter code * add newline between constants * address line length & rule length warnings * add comments * add comments * removed top level iteration * cleanup * update for test package * remove extra newline * fix boolean compare in unit tests * create constants for sharing settings * add naming convention for test package * remove extra space at end of file * fix json format * fix package naming pattern * fix policy indicated comments * refactor out duplicate code in test cases * remove unused var commit a5a679a Author: Dylan Gao <107067015+Dylan-MITRE@users.noreply.github.com> Date: Mon Dec 11 14:38:00 2023 -0500 add progress bar for OPA download (#682) * Update OPA.ps1 * Update OPA.ps1 * remove white space and requirement * Update OPA.ps1 revert to bit transfer and detailed error messages commit 8698efb Author: Richard Crutchfield <crutchfield@users.noreply.github.com> Date: Mon Dec 11 14:36:48 2023 -0500 Breaking dependency on opa in unit testing (#721) * Mock opa executable * Mock API Module * Add NoOpa to setup call * Backout unrelated change commit fe743e1 Author: Richard Crutchfield <crutchfield@users.noreply.github.com> Date: Mon Dec 11 13:34:37 2023 -0500 Remove PnP work-around (#725) commit 2b2b729 Author: mitchelbaker-cisa <149098823+mitchelbaker-cisa@users.noreply.github.com> Date: Mon Dec 11 09:09:34 2023 -0800 update unused variables to wildcards in DefenderConfig.rego, EXOConfig.rego, PowerPlatformConfig.rego, TeamsConfig.rego, ReportUtils.rego (up to v0.51.0) (#631) commit 2b4bb8e Author: Cassandra Diaz <47129205+Sloane4@users.noreply.github.com> Date: Thu Dec 7 16:33:40 2023 -0500 Download OPA only when required & Print real error message (#641) * Download only when needed & print real error * removed unneeded comment * added ability to take parameter input & removed hardcoded hash * cleanup * get hash from .sha256 file * update to check from acceptable version * add function to install opa for other os * update help message * Update OPA.ps1 Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update OPA.ps1 Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update OPA.ps1 Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update OPA.ps1 Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update SetUp.ps1 Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update OPA.ps1 Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * edge case fix * prevent user from accidently overwiting personal file --------- Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> commit bbb6c86 Author: James Garriss <52328727+james-garriss@users.noreply.github.com> Date: Wed Dec 6 10:21:52 2023 -0500 updated checkout action version (#692) * updated checkout action version * update checkout to v4 --------- Co-authored-by: James Garriss <jgarriss@mitre.org> commit 5016111 Author: David Bui <105074908+buidav@users.noreply.github.com> Date: Tue Dec 5 09:28:30 2023 -0800 add -UseBasicParsing to Invoke-WebRequest (#695) commit 7a11343 Author: Cassandra Diaz <47129205+Sloane4@users.noreply.github.com> Date: Tue Nov 28 11:14:14 2023 -0500 Address Rego Linter (Regal) Rules (#640) * Change ignore to warning for specified rules in issue * update style guide for new linter rules * change to warning for test-outside-test-package and rule-length * Update .regal/config.yaml Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update .regal/config.yaml Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update CONTENTSTYLEGUIDE.md Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update CONTENTSTYLEGUIDE.md Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * updated opa rego intro paragraph * removed extra sentance * removed bulletpoint * fix capitalization * add punctuation * word smithing * Update CONTENTSTYLEGUIDE.md Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> --------- Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> commit 8e46600 Author: Andrew Huynh <113476170+ahuynhMITRE@users.noreply.github.com> Date: Mon Nov 27 10:38:45 2023 -0500 added critcality (#690)
commit ff766d5 Author: Cassandra Diaz <47129205+Sloane4@users.noreply.github.com> Date: Wed Dec 13 18:03:26 2023 -0500 Refactor Exo Rego Code (#662) * first round of cleanup first round of cleanup * create helper funtion for conditions filter code create helper funtion for conditions filter code * add comments pt 1 add comments pt 1 add comments pt 2 add comments pt 2 * update syntax for constant update syntax for constant * update for test package update for test package * fix policy indicated comments fix policy indicated comments * fix json formatting & rego formatting fix json formatting & rego formatting * refactor out duplicate code in tests refactor out duplicate code in tests * remove unused imports remove unused imports * remove unused var remove unused var * remove constant commit d5cb929 Author: Cassandra Diaz <47129205+Sloane4@users.noreply.github.com> Date: Wed Dec 13 15:50:14 2023 -0500 Refactor Defender Rego Code (#663) * first round of cleanup * update for test package * fix policy spaces * fix json formatting & unfixed unit tests * refactor out duplicate code in test cases * refactor out OR checking duplicate code * add comments * add constants * add set comprehension to method call commit 29536fe Author: Cassandra Diaz <47129205+Sloane4@users.noreply.github.com> Date: Wed Dec 13 15:49:31 2023 -0500 Refactor AAD Rego Code (#664) * first round of cleanup * update for test package * update for constants * fix json formatting * remove extra newline * refactor out duplicate code in tests * add comments part 1 add comments part 2 * fix test cases * fix based on some comments commit f7cd368 Author: Richard Crutchfield <crutchfield@users.noreply.github.com> Date: Wed Dec 13 15:14:28 2023 -0500 Smoke test periodically fails (#728) * Rework download logic * Fix file path * Fix clean up * Update Testing/Functional/SmokeTest/UpdateSelenium.ps1 Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Add error action to download --------- Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> commit 883815c Author: Cassandra Diaz <47129205+Sloane4@users.noreply.github.com> Date: Wed Dec 13 09:10:32 2023 -0500 Refactor Teams Rego Code (#660) * first round of cleanup * address line length & rule length warnings. Also refactor duplicate code & constants * default over else line 413 * cleanup * add spacing * add comments * fix line length * update for test package * fix spacing * fix policy indicated comments * refactor out duplicate code in test cases * fix json formatting * remove unused var * Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/TeamsConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * update var name --------- Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> commit e623c92 Author: Cassandra Diaz <47129205+Sloane4@users.noreply.github.com> Date: Wed Dec 13 09:10:00 2023 -0500 Refactor Power Platform (#661) * first round of cleanup * create helper funtion for conditions filter code * add comments * update for test package * fix policy indicated comments * fix json formatting & rego formatting * refactor out duplicate code in test cases * Update Rego/PowerPlatformConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/PowerPlatformConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Update Rego/PowerPlatformConfig.rego Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> --------- Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> commit d88a16e Author: Cassandra Diaz <47129205+Sloane4@users.noreply.github.com> Date: Tue Dec 12 20:22:17 2023 -0500 Refactor Sharepoint Rego Code (#659) * add constants & reduce line lengths * removed unnecessary commas * create helper funtion for conditions filter code * add newline between constants * address line length & rule length warnings * add comments * add comments * removed top level iteration * cleanup * update for test package * remove extra newline * fix boolean compare in unit tests * create constants for sharing settings * add naming convention for test package * remove extra space at end of file * fix json format * fix package naming pattern * fix policy indicated comments * refactor out duplicate code in test cases * remove unused var commit a5a679a Author: Dylan Gao <107067015+Dylan-MITRE@users.noreply.github.com> Date: Mon Dec 11 14:38:00 2023 -0500 add progress bar for OPA download (#682) * Update OPA.ps1 * Update OPA.ps1 * remove white space and requirement * Update OPA.ps1 revert to bit transfer and detailed error messages commit 8698efb Author: Richard Crutchfield <crutchfield@users.noreply.github.com> Date: Mon Dec 11 14:36:48 2023 -0500 Breaking dependency on opa in unit testing (#721) * Mock opa executable * Mock API Module * Add NoOpa to setup call * Backout unrelated change commit fe743e1 Author: Richard Crutchfield <crutchfield@users.noreply.github.com> Date: Mon Dec 11 13:34:37 2023 -0500 Remove PnP work-around (#725) commit 2b2b729 Author: mitchelbaker-cisa <149098823+mitchelbaker-cisa@users.noreply.github.com> Date: Mon Dec 11 09:09:34 2023 -0800 update unused variables to wildcards in DefenderConfig.rego, EXOConfig.rego, PowerPlatformConfig.rego, TeamsConfig.rego, ReportUtils.rego (up to v0.51.0) (#631) commit 2b4bb8e Author: Cassandra Diaz <47129205+Sloane4@users.noreply.github.com> Date: Thu Dec 7 16:33:40 2023 -0500 Download OPA only when required & Print real error message (#641) * Download only when needed & print real error * removed unneeded comment * added ability to take parameter input & removed hardcoded hash * cleanup * get hash from .sha256 file * update to check from acceptable version * add function to install opa for other os * update help message * Update OPA.ps1 Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update OPA.ps1 Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update OPA.ps1 Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update OPA.ps1 Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update SetUp.ps1 Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update OPA.ps1 Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * edge case fix * prevent user from accidently overwiting personal file --------- Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> commit bbb6c86 Author: James Garriss <52328727+james-garriss@users.noreply.github.com> Date: Wed Dec 6 10:21:52 2023 -0500 updated checkout action version (#692) * updated checkout action version * update checkout to v4 --------- Co-authored-by: James Garriss <jgarriss@mitre.org> commit 5016111 Author: David Bui <105074908+buidav@users.noreply.github.com> Date: Tue Dec 5 09:28:30 2023 -0800 add -UseBasicParsing to Invoke-WebRequest (#695) commit 7a11343 Author: Cassandra Diaz <47129205+Sloane4@users.noreply.github.com> Date: Tue Nov 28 11:14:14 2023 -0500 Address Rego Linter (Regal) Rules (#640) * Change ignore to warning for specified rules in issue * update style guide for new linter rules * change to warning for test-outside-test-package and rule-length * Update .regal/config.yaml Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update .regal/config.yaml Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update CONTENTSTYLEGUIDE.md Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update CONTENTSTYLEGUIDE.md Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * updated opa rego intro paragraph * removed extra sentance * removed bulletpoint * fix capitalization * add punctuation * word smithing * Update CONTENTSTYLEGUIDE.md Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> --------- Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> commit 8e46600 Author: Andrew Huynh <113476170+ahuynhMITRE@users.noreply.github.com> Date: Mon Nov 27 10:38:45 2023 -0500 added critcality (#690)
🗣 Description
Added the html formatting for criticality to support new field in report for future proofing and consistency to match other baselines.
💭 Motivation and context
Criticality HTML is added to support new report field and supporting automation.
Closes #689
✅ Pre-approval checklist
in code comments.
✅ Pre-merge checklist
✅ Post-merge checklist