Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DoH Retry for NXDOMAIN #795

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Conversation

adhilto
Copy link
Collaborator

@adhilto adhilto commented Jan 12, 2024

🗣 Description

  • Adjust DNS query logic so that a retry over DoH is not triggered by NXDOMAIN.
  • Make EXO PowerShell compliant with the new linter

💭 Motivation and context

Closes #764. Aims to reduce warning fatigue.

🧪 Testing

  • Ran against the regular testing tenant, all results are correct
  • Ran the Invoke-RobustDnsTxt function in one of the pilot environments that has the empty DNS response issue. Retries over DoH still occurred as designed.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

@adhilto adhilto added the enhancement This issue or pull request will add new or improve existing functionality label Jan 12, 2024
@adhilto adhilto added this to the Flipper milestone Jan 12, 2024
@adhilto adhilto self-assigned this Jan 12, 2024
Copy link
Contributor

@crutchfield crutchfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Linter errors not related to PR.

Copy link
Collaborator

@nanda-katikaneni nanda-katikaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - done a few tests with existing test tenants, no issues. Approving.

@nanda-katikaneni nanda-katikaneni merged commit 001c1fd into flipper Jan 18, 2024
10 of 11 checks passed
@nanda-katikaneni nanda-katikaneni deleted the 764-redefine-dns-failure branch January 18, 2024 16:25
@schrolla schrolla linked an issue Jan 18, 2024 that may be closed by this pull request
2 tasks
schrolla pushed a commit that referenced this pull request Jan 19, 2024
* dont trigger doh on nxdomain

* Made changes to comply with PowerShell linter for EXO
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue or pull request will add new or improve existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redefine "failure" for DNS queries
3 participants