-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Json Output #970
Create Json Output #970
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - two observations:
- The individual 'json' reports appear to be not needed - is it useful to clean them up.
- The defining of a function so it can be found to mock suggestion is optional. I have been changing them as I revisit tests.
PowerShell/ScubaGear/Testing/Unit/PowerShell/Orchestrator/Invoke-RunCached.Tests.ps1
Outdated
Show resolved
Hide resolved
…ke-RunCached.Tests.ps1 Co-authored-by: Richard Crutchfield <crutchfield@users.noreply.github.com>
David had a similar suggestion, so I will make that change. He also recommended I add a switch to keep the size of the output down. If true, create the ScubaResults.json file and delete the redundant files (the individual jsons you mentioned and the provider output). If false, don't create ScubaResults.json, just execute as normal. Unless you have any objections, I'll go ahead and make both changes. |
Sounds good to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, however have one last comment.
Co-authored-by: David Bui <105074908+buidav@users.noreply.github.com>
@nanda-katikaneni this PR is ready |
🗣 Description
Create a single json file (defaults to ScubaResults.json) that contains all of the ScubaGear output, including:
💭 Motivation and context
Closes #913.
🧪 Testing
✅ Pre-approval checklist
✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branch
button below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
✅ Post-merge checklist