Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GWS.GMAIL.7.6 has the wrong criticality in the code #397

Closed
adhilto opened this issue Sep 10, 2024 · 1 comment · Fixed by #394
Closed

GWS.GMAIL.7.6 has the wrong criticality in the code #397

adhilto opened this issue Sep 10, 2024 · 1 comment · Fixed by #394
Assignees
@snarve
Labels
bug This issue or pull request addresses broken functionality Gmail
Milestone
Coast

Comments

@adhilto
Copy link
Collaborator

adhilto commented Sep 10, 2024

🐛 Summary

GWS.GMAIL.7.6 is a "SHALL" control, but the criticality listed in the Rego is "Should."

To reproduce

  1. Change one of the spoofing settings to "keep in inbox"
  2. Run ScubaGoggles. Note that 7.6 shows as a "Warning" not a "Failure"

Expected behavior

5.5 non-compliance to be reported as a failure.

Any helpful log output or screenshots

image
@adhilto adhilto added the bug This issue or pull request addresses broken functionality label Sep 10, 2024
snarve added a commit that referenced this issue Sep 10, 2024
@snarve
[#397] Update criticality for policy 7.6
2ed05c8
@snarve snarve self-assigned this Sep 11, 2024
@snarve snarve added the Gmail label Sep 11, 2024
@snarve snarve mentioned this issue Sep 11, 2024
Merged
14 tasks
@snarve snarve added this to the Coast milestone Sep 11, 2024
@snarve
Copy link
Collaborator

snarve commented Sep 11, 2024

Covered in PR #394

adhilto pushed a commit that referenced this issue Sep 11, 2024
@snarve
[#294, #295] Update Gmail policies 5 and 7 to include all instances o…
9a4bbc8 
…f spoofing and authentication settings that are not complaint (#394)

* [#295] Update policy 7

* [#295] Update policy 7 to handle multiple settings detailed report message

* [#295] Cleanup

* [#295] Update 7.6 and 5.5

* [#295] Update policy 5 and 7

* [#295] Format the report output

* [#295] Fix formatting for policy 7 and rename variables with more logical names

* [#295] Rename policy 5 and 7 variables and formatting updates

* [#295] Unit tests updated

* [#294] Fix linter issues

* [#294] Linter formatting

* [#294] More formatting

* [#295] Try different format for linter

* [#295] Remove if statement

* [#295] Use different assignment operator

* [#295] Update assignment operator for policy 5

* Linter fix

* More linter fixes

* Linter formatting

* Linter again

* Update array format

* Remove comma

* Remove array notation

* Replace assignment operator

* Refactor functions

* Typo fixed

* [#396] Updated the criticality for policy 5.5

* [#397] Update criticality for policy 7.6

* PR updates

* Remove typo

* Update message for setting

* Update unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snarve snarve

Labels
bug This issue or pull request addresses broken functionality Gmail
Projects
None yet
Milestone
Coast
2 participants
@adhilto @snarve