Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Detailed report messages for Drive&Docs #300

Merged
merged 36 commits into from
Jul 15, 2024

Conversation

snarve
Copy link
Collaborator

@snarve snarve commented Jun 3, 2024

🗣 Description

Update Drive and Docs rego and unit tests to support detailed report messages and group override policy

Closes #259
Closes #282
Closes #196

💭 Motivation and context

This issue is part of the epic #190 and #90

🧪 Testing

Ensure all use cases for report and unit tests pass

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@snarve snarve added this to the Barracuda milestone Jun 3, 2024
@snarve snarve linked an issue Jun 3, 2024 that may be closed by this pull request
@adhilto adhilto self-requested a review June 3, 2024 18:10
@snarve snarve requested a review from buidav June 3, 2024 22:18
Copy link
Collaborator

@adhilto adhilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't finished my review yet (only done 1.1, 1,2, and 1.3 so far), but I'm releasing these comments now to get you feedback sooner.

rego/Drive.rego Outdated Show resolved Hide resolved
rego/Drive.rego Outdated Show resolved Hide resolved
rego/Drive.rego Outdated Show resolved Hide resolved
rego/Drive.rego Show resolved Hide resolved
@buidav buidav modified the milestones: Barracuda, Coast Jun 5, 2024
@LaurenBassett
Copy link
Collaborator

It looks like the last edit requested by Alden was completed by Sheetal yesterday! Looks like it should be good to go now?

@adhilto
Copy link
Collaborator

adhilto commented Jun 5, 2024

It looks like the last edit requested by Alden was completed by Sheetal yesterday! Looks like it should be good to go now?

Unfortunately, this PR won't make it in time for this release. I only reviewed group 1. We didn't have enough time to get to the remaining groups.

@LaurenBassett
Copy link
Collaborator

It looks like the last edit requested by Alden was completed by Sheetal yesterday! Looks like it should be good to go now?

Unfortunately, this PR won't make it in time for this release. I only reviewed group 1. We didn't have enough time to get to the remaining groups.

Gotcha. All good.

Copy link
Collaborator

@adhilto adhilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished my review! Here are my remaining comments.

rego/Drive.rego Outdated Show resolved Hide resolved
rego/Drive.rego Outdated Show resolved Hide resolved
rego/Drive.rego Outdated Show resolved Hide resolved
rego/Drive.rego Outdated Show resolved Hide resolved
rego/Drive.rego Outdated Show resolved Hide resolved
rego/Drive.rego Outdated Show resolved Hide resolved
rego/Drive.rego Outdated Show resolved Hide resolved
Copy link
Collaborator

@buidav buidav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small spacing requests.
1 question.

rego/Drive.rego Show resolved Hide resolved
rego/Drive.rego Show resolved Hide resolved
@buidav buidav requested review from buidav and adhilto July 12, 2024 02:18
@buidav
Copy link
Collaborator

buidav commented Jul 12, 2024

@adhilto fat fingered the review button and accidentally requested your rereview.

@buidav buidav changed the title 259 detailed report message for drive docs Add Detailed report messages for Drive&Docs Jul 12, 2024
Copy link
Collaborator

@buidav buidav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@adhilto adhilto merged commit d463678 into main Jul 15, 2024
17 checks passed
@adhilto adhilto deleted the 259-detailed-report-message-for-drive-docs branch July 15, 2024 17:58
@snarve snarve requested review from mitchelbaker-cisa and LaurenBassett and removed request for LaurenBassett and mitchelbaker-cisa August 7, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants