Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Policy 5.1 for Meet for 1:1 Calling #316

Merged
merged 8 commits into from
Jun 20, 2024
Merged

New Policy 5.1 for Meet for 1:1 Calling #316

merged 8 commits into from
Jun 20, 2024

Conversation

mdueltgen
Copy link
Collaborator

@mdueltgen mdueltgen commented Jun 11, 2024 •
edited by buidav
Loading

🗣 Description

Added in the Policy for Meet for 1:1 Calling as
The following changes were made.

  • Added Policy Group 5
  • Added Policy 5.1 and implementation steps

Fixes #224

💭 Motivation and context

Google product update required a new policy. Changes were made based on internal discussion.

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@mdueltgen mdueltgen added this to the Coast milestone Jun 11, 2024
adhilto
adhilto requested changes Jun 11, 2024
View reviewed changes
baselines/Google Meet Minimum Viable Secure Configuration Baseline v0.2.md Outdated Show resolved Hide resolved
baselines/Google Meet Minimum Viable Secure Configuration Baseline v0.2.md Outdated Show resolved Hide resolved
baselines/Google Meet Minimum Viable Secure Configuration Baseline v0.2.md Show resolved Hide resolved
baselines/Google Meet Minimum Viable Secure Configuration Baseline v0.2.md Outdated Show resolved Hide resolved
baselines/Google Meet Minimum Viable Secure Configuration Baseline v0.2.md Outdated Show resolved Hide resolved
baselines/Google Meet Minimum Viable Secure Configuration Baseline v0.2.md Outdated Show resolved Hide resolved
drift-rules/GWS Drift Monitoring Rules - Meet.csv Outdated Show resolved Hide resolved
mdueltgen and others added 4 commits June 12, 2024 09:54
@mdueltgen @adhilto
Update drift-rules/GWS Drift Monitoring Rules - Meet.csv
f9bb2d2 
Correcting Version Number

Co-authored-by: Alden Hilton <106177711+adhilto@users.noreply.github.com>
@mdueltgen @adhilto
Update baselines/Google Meet Minimum Viable Secure Configuration Base…
618e515 
…line v0.2.md


Correct Version Number

Co-authored-by: Alden Hilton <106177711+adhilto@users.noreply.github.com>
@mdueltgen @adhilto
Update baselines/Google Meet Minimum Viable Secure Configuration Base…
ed63e68 
…line v0.2.md


Correct Version Number

Co-authored-by: Alden Hilton <106177711+adhilto@users.noreply.github.com>
@jkaufman-mitre @adhilto
Apply suggestions from code review
0dcd699 
Co-authored-by: Alden Hilton <106177711+adhilto@users.noreply.github.com>
@adhilto
Copy link
Collaborator

adhilto commented Jun 18, 2024

@jkaufman-mitre @mdueltgen Thanks for addressing my feedback. I'll make the code changes now.

@mdueltgen mdueltgen requested a review from adhilto June 18, 2024 16:45
@jkaufman-mitre @buidav
Apply suggestions from code review
3539f4b 
Co-authored-by: David Bui <105074908+buidav@users.noreply.github.com>
jkaufman-mitre
jkaufman-mitre approved these changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@jkaufman-mitre jkaufman-mitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me.

@buidav buidav changed the title New Policy for Meet for 1:1 Calling New Policy 5.1 for Meet for 1:1 Calling Jun 20, 2024
@buidav buidav merged commit f946599 into main Jun 20, 2024
4 checks passed
@buidav buidav deleted the meet-changes-post-0.2 branch June 20, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkaufman-mitre jkaufman-mitre jkaufman-mitre approved these changes

@adhilto adhilto adhilto approved these changes

@buidav buidav buidav approved these changes

@prodjom prodjom Awaiting requested review from prodjom

Assignees

@jkaufman-mitre jkaufman-mitre

@mdueltgen mdueltgen

Labels
Baseline Revision Code Changes Required Google Meet High
Projects
None yet
Milestone
Coast
Development

Successfully merging this pull request may close these issues.

Create a Policy in Meet for 1:1 Calling
4 participants
@mdueltgen @adhilto @buidav @jkaufman-mitre