Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Omit to the Summary Counts #346

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Add Omit to the Summary Counts #346

merged 2 commits into from
Aug 21, 2024

Conversation

adhilto
Copy link
Collaborator

@adhilto adhilto commented Aug 15, 2024 •
edited
Loading

🗣 Description

Add "Omit" to the summary counts. HTML output is unchanged, JSON output now looks like this:
image

💭 Motivation and context

Closes #345

🧪 Testing

Tested manually, worked as expected.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@adhilto adhilto added this to the Coast milestone Aug 15, 2024
@adhilto adhilto self-assigned this Aug 15, 2024
@adhilto adhilto linked an issue Aug 15, 2024 that may be closed by this pull request
Add "omit" to the summary counts #345
Closed
1 task
@snarve snarve self-requested a review August 20, 2024 17:42
@adhilto adhilto merged commit 6a01021 into main Aug 21, 2024
6 checks passed
@adhilto adhilto deleted the 345-add-omit-to-the-summary-counts branch August 21, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchelbaker-cisa mitchelbaker-cisa mitchelbaker-cisa approved these changes

@rlxdev rlxdev rlxdev approved these changes

@snarve snarve Awaiting requested review from snarve

Assignees

@adhilto adhilto

Labels
enhancement
Projects
None yet
Milestone
Coast
Development

Successfully merging this pull request may close these issues.

Add "omit" to the summary counts
3 participants
@adhilto @rlxdev @mitchelbaker-cisa