-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eel Baseline Version Bump to v1 #641
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updates in the baselines and the drift rules look good, however this will require code changes as well. The current change breaks the code. Do we plan to address that in this issue itself or will create a separate issue that will need a quick fix to avoid breaking code changes.
The breaking change is due to the format change in the version numbering from v0.4.x to v1 (code expects .separated version number)
e757b52
to
34b8179
Compare
I quickly updated this to include the minor version, which is still what we want to do, right? |
Post v1, the baseline numbering will be different, which means each baseline number will be updated only if the baseline has been updated (there are restrictions on this as well, meaning which updates call for a change in the numbering). This is to be consistent with ScubaGear/M365 Baselines. So, say Chat policy CHAT.1.1v1 if updated and requires a numbering update, will become CHAT.1.1v1.1. However, CHAT.1.2v1 will remain unchanged if there are no updates. |
So, if we're at a "major" version release, the baselines get no minor version number, but if they happen to change during a "point" release, they get a major and minor version number? This will require code changes (not major), but I'm wondering what the benefit is to having some baselines v1, v2, v3, and v1.3, v2.5, and not v1.0, v1.1, v1.2. |
34b8179
to
e757b52
Compare
Actually, the control versions will never have minor versions. So in the example @snarve gave, the new version would be GWS.CHAT.1.1v2. For example:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rlxdev the code updates for the version bump need to merge the latest from main (specifically the new setup instructions) since now the report errors out
It returns a permission denied error on .scubagoggles (directory)
7dca93e
to
75b3e10
Compare
I rebased this branch to main, so this will get the recently merged changes for the setup/installation. Testing should work for anyone who has had their setup converted to the new setup changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Thanks for the update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the unit tests are not able to find the opa executable, throws an error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted the unit tests issue as a separate bug: #648
Approving this PR
π£ Description
Bumping version number to be ready for Eel release and be consitent with ScubaGear
π Motivation and context
Closes #632
π§ͺ Testing
N/A
β Pre-approval checklist
β Pre-merge Checklist
Squash and merge
button.β Post-merge Checklist