Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static 508 banner text for local dev builds and cleanup logging #355

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

nickviola
Copy link
Collaborator

@nickviola nickviola commented Jun 20, 2024

Return a hardcoded 508 compliance warning banner for local dev builds instead of pulling from s3 bucket. Cleanup old console.logs that were no longer needed.

🗣 Description

💭 Motivation and context

It was decided to use this solution over providing individual AWS access keys.

🧪 Testing

Make sure local .env file includes:

IS_LOCAL=1

Login to localhost as usual and you should see the banner without access keys setup. To confirm that it's using the hardcoded value, check the backend container log output to be sure that`

Using default banner for 508 warning:

is displayed.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

Copy link
Contributor

@ameliav ameliav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmelz21 schmelz21 merged commit 0fb5d32 into develop Jun 27, 2024
15 of 18 checks passed
@schmelz21 schmelz21 deleted the add-static-508-banner-text-for-local-dev-builds branch June 27, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants