-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Severity Label validation to All Vulns table (CRASM-822) #720
Added Severity Label validation to All Vulns table (CRASM-822) #720
Conversation
- Ensured that null or empty string values are displayed as 'N/A' in the severity column of the All Vulns table. - Ensured that values of Other or any value that does not include 'Critical', 'High', 'Medium', or 'Low' are displayed as 'Other' in the severity column of the All Vulns table.. - Formatted the severity column of the All Vulns table to display the severity label in title case. - Updated the vulnerability search endpoint to return vulnerabilities with a severity of 'Other' if the severity is not 'Critical', 'High', 'Medium', or 'Low'. - Updated the vulnerability search endpoint to return vulnerabilities with a severity of 'N/A' if the severity is null or an empty string. - Updated the vulnerability search endpoint to return vulnerabilities regardless of the case of the severity value.
- Could be from the HTML encodings for the org search introduced in CRASM-746/PR #691
- Added an if statement and a console.log to help troubleshoot a github actions issue. - This change was reverted because it was erroneously included in the draft pull request.
…ll-Vulns-CRASM-822
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found two small bugs, resolved these together with @hawkishpolicy
LGTM after checks pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ll-Vulns-CRASM-822
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🗣 Description
💭 Motivation and context
🧪 Testing
📷 Screenshots (if appropriate)
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist